Skip to content

Commit ae49969

Browse files
nan-wangnan-wang
authored
ci: fix the wrong error msg (#882)
* ci: fix the wrong error msg Signed-off-by: Nan Wang <nan.wang@jina.ai> * ci: add debugging Signed-off-by: Nan Wang <nan.wang@jina.ai> * ci: fix the gramma Signed-off-by: Nan Wang <nan.wang@jina.ai> * ci: fix the gramma Signed-off-by: Nan Wang <nan.wang@jina.ai> * ci: fix the gramma Signed-off-by: Nan Wang <nan.wang@jina.ai> * chore: clean up readme Signed-off-by: Nan Wang <nan.wang@jina.ai> * ci: fix the gramma Signed-off-by: Nan Wang <nan.wang@jina.ai> * ci: fix the gramma Signed-off-by: Nan Wang <nan.wang@jina.ai> * chore: clean up readme Signed-off-by: Nan Wang <nan.wang@jina.ai> * chore: clean up readme Signed-off-by: Nan Wang <nan.wang@jina.ai> * ci: remove the debugging lines Signed-off-by: Nan Wang <nan.wang@jina.ai> Signed-off-by: Nan Wang <nan.wang@jina.ai>
1 parent 59db0ff commit ae49969

3 files changed

Lines changed: 12 additions & 13 deletions

File tree

‎.github/workflows/cd.yml‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,8 @@ jobs:
146146

147147
check-readme-modification:
148148
runs-on: ubuntu-latest
149+
outputs:
150+
readme_changed: ${{ steps.step_output.outputs.readme_changed }}
149151
steps:
150152
- uses: actions/checkout@v3
151153
with:
@@ -159,16 +161,13 @@ jobs:
159161
README.md
160162
161163
- name: Check if README is modified
164+
id: step_output
162165
if: steps.changed-files-specific.outputs.any_changed == 'true'
163166
run: |
164-
echo "README.md is modified"
165-
touch SUCCESS
166-
167-
- name: Return outputs
168-
run: |
169-
[[ -f SUCCESS ]]
167+
echo "readme_changed=true" >> $GITHUB_OUTPUT
170168
171169
publish-docarray-org:
172170
needs: check-readme-modification
171+
if: needs.check-readme-modification.outputs.readme_changed == 'true'
173172
uses: ./.github/workflows/publish-docarray-org.yml
174173
secrets: inherit

‎.github/workflows/publish-docarray-org.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
- name: Check trigger event
3232
run: |
3333
touch SUCCESS
34-
if: github.event_name == 'pull_request'
34+
if: ${{ github.event_name == 'pull_request' || github.event_name == 'push' }}
3535
- name: Fail release token
3636
run: |
3737
[[ -f SUCCESS ]]

‎README.md‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -167,10 +167,10 @@ Let's use DocArray and the [Totally Looks Like](https://sites.google.com/view/to
167167
</thead>
168168
<tbody>
169169
<tr align="center">
170-
<td><img src="https://github.com/jina-ai/docarray/blob/main/.github/README-img/left-00018.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
171-
<td><img src="https://github.com/jina-ai/docarray/blob/main/.github/README-img/right-00018.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
172-
<td><img src="https://github.com/jina-ai/docarray/blob/main/.github/README-img/left-00131.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
173-
<td><img src="https://github.com/jina-ai/docarray/blob/main/.github/README-img/right-00131.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
170+
<td><img src="https://github.com/docarray/docarray/blob/main/.github/README-img/left-00018.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
171+
<td><img src="https://github.com/docarray/docarray/blob/main/.github/README-img/right-00018.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
172+
<td><img src="https://github.com/docarray/docarray/blob/main/.github/README-img/left-00131.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
173+
<td><img src="https://github.com/docarray/docarray/blob/main/.github/README-img/right-00131.jpg?raw=true" alt="Visualizing top-9 matches using DocArray API" width="50%"></td>
174174
</tr>
175175
</tbody>
176176
</table>
@@ -206,7 +206,7 @@ left_da.plot_image_sprites()
206206
```
207207

208208
<p align="center">
209-
<a href="https://docarray.jina.ai"><img src="https://github.com/jina-ai/docarray/blob/main/.github/README-img/sprite.png?raw=true" alt="Load totally looks like dataset with docarray API" width="60%"></a>
209+
<a href="https://docarray.jina.ai"><img src="https://github.com/docarray/docarray/blob/main/.github/README-img/sprite.png?raw=true" alt="Load totally looks like dataset with docarray API" width="60%"></a>
210210
</p>
211211

212212
### Apply preprocessing
@@ -252,7 +252,7 @@ left_da.plot_embeddings(image_sprites=True)
252252
```
253253

254254
<p align="center">
255-
<a href="https://docarray.jina.ai"><img src="https://github.com/jina-ai/docarray/blob/main/.github/README-img/tsne.gif?raw=true" alt="Visualizing embedding via tSNE and embedding projector" width="90%"></a>
255+
<a href="https://docarray.jina.ai"><img src="https://github.com/docarray/docarray/blob/main/.github/README-img/tsne.gif?raw=true" alt="Visualizing embedding via tSNE and embedding projector" width="90%"></a>
256256
</p>
257257

258258
Fun is fun, but recall our goal is to match left images against right images and so far we have only handled the left. Let's repeat the same procedure for the right:

0 commit comments

Comments
 (0)