fix: detect default this binding in Array.fromAsync callbacks (#20456)

fasttime · web-flow · commit 1d29d22fe302 · 2026-01-28T15:54:35.000+01:00
diff --git a/lib/rules/utils/ast-utils.js b/lib/rules/utils/ast-utils.js
@@ -526,6 +526,15 @@ function isArrayFromMethod(node) {
 	return isSpecificMemberAccess(node, arrayOrTypedArrayPattern, "from");
 }
 
+/**
+ * Checks whether or not a node is `Array.fromAsync`.
+ * @param {ASTNode} node A node to check.
+ * @returns {boolean} Whether or not the node is a `Array.fromAsync`.
+ */
+function isArrayFromAsyncMethod(node) {
+	return isSpecificMemberAccess(node, "Array", "fromAsync");
+}
+
 /**
  * Checks whether or not a node is a method which expects a function as a first argument, and `thisArg` as a second argument.
  * @param {ASTNode} node A node to check.
@@ -1462,6 +1471,7 @@ module.exports = {
 	isLoop,
 	isInLoop,
 	isArrayFromMethod,
+	isArrayFromAsyncMethod,
 	isParenthesised,
 	createGlobalLinebreakMatcher,
 	equalTokens,
@@ -1793,7 +1803,10 @@ module.exports = {
 							isNullOrUndefined(parent.arguments[1])
 						);
 					}
-					if (isArrayFromMethod(parent.callee)) {
+					if (
+						isArrayFromMethod(parent.callee) ||
+						isArrayFromAsyncMethod(parent.callee)
+					) {
 						return (
 							parent.arguments.length !== 3 ||
 							parent.arguments[1] !== currentNode ||
diff --git a/tests/lib/rules/no-eval.js b/tests/lib/rules/no-eval.js
@@ -135,6 +135,10 @@ ruleTester.run("no-eval", rule, {
 		"array.findLast(function (x) { return this.eval.includes(x); }, { eval: ['foo', 'bar'] });",
 		"callbacks.findLastIndex(function (cb) { return cb(this.eval); }, this);",
 		"['1+1'].flatMap(function (str) { return this.eval(str); }, new Evaluator);",
+		{
+			code: "Array.fromAsync(values, async function (value) { return this.eval(await value); }, context);",
+			languageOptions: { ecmaVersion: 2017 },
+		},
 
 		// Allows indirect eval
 		{ code: "(0, eval)('foo')", options: [{ allowIndirect: true }] },
diff --git a/tests/lib/rules/no-invalid-this.js b/tests/lib/rules/no-invalid-this.js
@@ -481,13 +481,13 @@ const patterns = [
 	},
 
 	// Array methods.
-	{
-		code: "Array.from([], function() { console.log(this); z(x => console.log(x, this)); });",
+	...["from", "fromAsync"].map(methodName => ({
+		code: `Array.${methodName}([], function() { console.log(this); z(x => console.log(x, this)); });`,
 		languageOptions: { ecmaVersion: 6 },
 		errors,
 		valid: [NORMAL],
 		invalid: [USE_STRICT, IMPLIED_STRICT, MODULES],
-	},
+	})),
 	...[
 		"every",
 		"filter",
@@ -506,12 +506,12 @@ const patterns = [
 		valid: [NORMAL],
 		invalid: [USE_STRICT, IMPLIED_STRICT, MODULES],
 	})),
-	{
-		code: "Array.from([], function() { console.log(this); z(x => console.log(x, this)); }, obj);",
+	...["from", "fromAsync"].map(methodName => ({
+		code: `Array.${methodName}([], function() { console.log(this); z(x => console.log(x, this)); }, obj);`,
 		languageOptions: { ecmaVersion: 6 },
 		valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
 		invalid: [],
-	},
+	})),
 	...[
 		"every",
 		"filter",
@@ -1123,6 +1123,17 @@ ruleTesterTypeScript.run("no-invalid-this", rule, {
     );
         `,
 
+		`
+    Array.fromAsync(
+      [],
+      function () {
+        console.log(this);
+        z(x => console.log(x, this));
+      },
+      obj,
+    );
+        `,
+
 		`
     foo.every(function () {
       console.log(this);
@@ -1606,6 +1617,15 @@ ruleTesterTypeScript.run("no-invalid-this", rule, {
 		},
 		{
 			code: `
+    Array.fromAsync([], function () {
+      console.log(this);
+      z(x => console.log(x, this));
+    });
+          `,
+			errors,
+		},
+		{
+			code: `
     foo.every(function () {
       console.log(this);
       z(x => console.log(x, this));
