feat!: update eslint:recommended configuration (#20210)

Pixel998 · web-flow · commit 454a292c95f3 · 2025-11-07T23:01:07.000+01:00
* feat!: update `eslint:recommended` configuration

* revert docs changes

* revert eslint-config-eslint changes

* fix formatting

* add v10 migration note for `eslint:recommended` updates
diff --git a/docs/src/use/migrate-to-10.0.0.md b/docs/src/use/migrate-to-10.0.0.md
@@ -18,6 +18,7 @@ The lists below are ordered roughly by the number of users each change is expect
 - [Node.js < v20.19, v21, v23 are no longer supported](#drop-old-node)
 - [New configuration file lookup algorithm](#config-lookup-from-file)
 - [`no-shadow-restricted-names` now reports `globalThis` by default](#no-shadow-restricted-names)
+- [`eslint:recommended` has been updated](#eslint-recommended)
 
 ### Breaking changes for plugin developers
 
@@ -74,3 +75,15 @@ In ESLint v10, the [`no-shadow-restricted-names`](../rules/no-shadow-restricted-
 ```
 
 **Related issue(s):** [#19673](https://github.com/eslint/eslint/issues/19673)
+
+## <a name="eslint-recommended"></a> `eslint:recommended` has been updated
+
+Three new rules have been enabled in `eslint:recommended`:
+
+- [`no-unassigned-vars`](../rules/no-unassigned-vars)
+- [`no-useless-assignment`](../rules/no-useless-assignment)
+- [`preserve-caught-error`](../rules/preserve-caught-error)
+
+**To address:** Fix errors or disable these rules.
+
+**Related issue(s):** [#19966](https://github.com/eslint/eslint/issues/19966)
diff --git a/lib/rules/no-unassigned-vars.js b/lib/rules/no-unassigned-vars.js
@@ -18,7 +18,7 @@ module.exports = {
 		docs: {
 			description:
 				"Disallow `let` or `var` variables that are read but never assigned",
-			recommended: false,
+			recommended: true,
 			url: "https://eslint.org/docs/latest/rules/no-unassigned-vars",
 		},
 
diff --git a/lib/rules/no-useless-assignment.js b/lib/rules/no-useless-assignment.js
@@ -130,7 +130,7 @@ module.exports = {
 		docs: {
 			description:
 				"Disallow variable assignments when the value is not used",
-			recommended: false,
+			recommended: true,
 			url: "https://eslint.org/docs/latest/rules/no-useless-assignment",
 		},
 
diff --git a/lib/rules/preserve-caught-error.js b/lib/rules/preserve-caught-error.js
@@ -158,7 +158,7 @@ module.exports = {
 		docs: {
 			description:
 				"Disallow losing originally caught error when re-throwing custom errors",
-			recommended: false,
+			recommended: true,
 			url: "https://eslint.org/docs/latest/rules/preserve-caught-error", // URL to the documentation page for this rule
 		},
 		/*
diff --git a/lib/types/rules.d.ts b/lib/types/rules.d.ts
@@ -3914,6 +3914,9 @@ export interface ESLintRules extends Linter.RulesRecord {
 	/**
 	 * Rule to disallow `let` or `var` variables that are read but never assigned.
 	 *
+	 * @remarks
+	 * Recommended by ESLint, the rule was enabled in `eslint:recommended`.
+	 *
 	 * @since 9.27.0
 	 * @see https://eslint.org/docs/latest/rules/no-unassigned-vars
 	 */
@@ -4279,6 +4282,9 @@ export interface ESLintRules extends Linter.RulesRecord {
 	/**
 	 * Rule to disallow variable assignments when the value is not used.
 	 *
+	 * @remarks
+	 * Recommended by ESLint, the rule was enabled in `eslint:recommended`.
+	 *
 	 * @since 9.0.0-alpha.1
 	 * @see https://eslint.org/docs/latest/rules/no-useless-assignment
 	 */
@@ -4944,6 +4950,9 @@ export interface ESLintRules extends Linter.RulesRecord {
 	/**
 	 * Rule to disallow losing originally caught error when re-throwing custom errors.
 	 *
+	 * @remarks
+	 * Recommended by ESLint, the rule was enabled in `eslint:recommended`.
+	 *
 	 * @since 9.35.0
 	 * @see https://eslint.org/docs/latest/rules/preserve-caught-error
 	 */
diff --git a/packages/js/src/configs/eslint-recommended.js b/packages/js/src/configs/eslint-recommended.js
@@ -59,6 +59,7 @@ module.exports = Object.freeze({
         "no-shadow-restricted-names": "error",
         "no-sparse-arrays": "error",
         "no-this-before-super": "error",
+        "no-unassigned-vars": "error",
         "no-undef": "error",
         "no-unexpected-multiline": "error",
         "no-unreachable": "error",
@@ -68,10 +69,12 @@ module.exports = Object.freeze({
         "no-unused-labels": "error",
         "no-unused-private-class-members": "error",
         "no-unused-vars": "error",
+        "no-useless-assignment": "error",
         "no-useless-backreference": "error",
         "no-useless-catch": "error",
         "no-useless-escape": "error",
         "no-with": "error",
+        "preserve-caught-error": "error",
         "require-yield": "error",
         "use-isnan": "error",
         "valid-typeof": "error"
