fix: use MessagePlaceholderData type from @eslint/core (#20348)

lumirlumir · web-flow · commit f244dbf21912 · 2026-01-10T14:36:06.000+01:00
diff --git a/lib/types/index.d.ts b/lib/types/index.d.ts
@@ -70,6 +70,7 @@ import type {
 	SuggestedEditBase,
 	SuggestedEdit,
 	ViolationReport,
+	MessagePlaceholderData,
 } from "@eslint/core";
 
 //------------------------------------------------------------------------------
@@ -1458,7 +1459,7 @@ export namespace RuleTester {
 	interface SuggestionOutput {
 		messageId?: string;
 		desc?: string;
-		data?: Record<string, unknown> | undefined;
+		data?: MessagePlaceholderData | undefined;
 		output: string;
 	}
 
@@ -1470,7 +1471,7 @@ export namespace RuleTester {
 	interface TestCaseError {
 		message?: string | RegExp;
 		messageId?: string;
-		data?: any;
+		data?: MessagePlaceholderData | undefined;
 		line?: number | undefined;
 		column?: number | undefined;
 		endLine?: number | undefined;
diff --git a/tests/lib/types/types.test.ts b/tests/lib/types/types.test.ts
@@ -1844,6 +1844,52 @@ ruleTester.run("my-rule", rule, {
 		{ code: "foo", errors: [/foo/] },
 		{ code: "foo", errors: [{ message: "foo" }] },
 		{ code: "foo", errors: [{ message: "foo", data: { foo: true } }] },
+		{ code: "foo", errors: [{ message: "foo", data: undefined }] },
+		{
+			code: "foo",
+			errors: [
+				{
+					message: "foo",
+					// @ts-expect-error -- `data` cannot be `null`
+					data: null,
+				},
+			],
+		},
+		{
+			code: "foo",
+			errors: [
+				{
+					message: "foo",
+					data: {
+						foo: "foo",
+						bar: 1,
+						baz: true,
+						qux: false,
+						a: 1n,
+						b: null,
+						c: undefined,
+						d: void 0,
+						// @ts-expect-error -- Symbols are not allowed in `data`.
+						e: Symbol("b"),
+						// @ts-expect-error -- Objects are not allowed in `data`.
+						f: {
+							hi: "hi",
+						},
+						// @ts-expect-error -- Arrays are not allowed in `data`.
+						g: [1, 2, 3],
+						// @ts-expect-error -- Sets are not allowed in `data`.
+						h: new Set([1, 2, 3]),
+						// @ts-expect-error -- Maps are not allowed in `data`.
+						i: new Map([
+							["a", 1],
+							["b", 2],
+						]),
+						// @ts-expect-error -- Functions are not allowed in `data`.
+						j: () => {},
+					},
+				},
+			],
+		},
 		{ code: "foo", errors: [{ message: "foo", line: 0 }] },
 		{
 			code: "foo",
@@ -1859,6 +1905,49 @@ ruleTester.run("my-rule", rule, {
 							messageId: "foo",
 							output: "foo",
 						},
+						{
+							messageId: "foo",
+							output: "foo",
+							data: undefined,
+						},
+						{
+							messageId: "foo",
+							output: "foo",
+							// @ts-expect-error -- `data` cannot be `null`
+							data: null,
+						},
+						{
+							messageId: "foo",
+							desc: "foo",
+							output: "foo",
+							data: {
+								foo: "foo",
+								bar: 1,
+								baz: true,
+								qux: false,
+								a: 1n,
+								b: null,
+								c: undefined,
+								d: void 0,
+								// @ts-expect-error -- Symbols are not allowed in `data`.
+								e: Symbol("b"),
+								// @ts-expect-error -- Objects are not allowed in `data`.
+								f: {
+									hi: "hi",
+								},
+								// @ts-expect-error -- Arrays are not allowed in `data`.
+								g: [1, 2, 3],
+								// @ts-expect-error -- Sets are not allowed in `data`.
+								h: new Set([1, 2, 3]),
+								// @ts-expect-error -- Maps are not allowed in `data`.
+								i: new Map([
+									["a", 1],
+									["b", 2],
+								]),
+								// @ts-expect-error -- Functions are not allowed in `data`.
+								j: () => {},
+							},
+						},
 					],
 				},
 			],
