Skip to content

Commit 6be62fb

Browse files
author
Daniel Kim
committed
Rename instances of metadata to data
Signed-off-by: Daniel Kim <danielk@twitter.com>
1 parent 9b34987 commit 6be62fb

4 files changed

Lines changed: 23 additions & 23 deletions

File tree

ui/src/custom-tabs/metadata-tab/MetadataQuery.tsx renamed to ui/src/custom-tabs/data-tab/DataQuery.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { useQuery } from "react-query";
22

3-
interface MetadataQueryInterface {
3+
interface DataQueryInterface {
44
featureView: string | undefined;
55
}
66

7-
const MetadataQuery = (featureView: string) => {
8-
const queryKey = `metadata-tab-namespace:${featureView}`;
7+
const DataQuery = (featureView: string) => {
8+
const queryKey = `data-tab-namespace:${featureView}`;
99

1010
return useQuery<any>(
1111
queryKey,
@@ -22,4 +22,4 @@ const MetadataQuery = (featureView: string) => {
2222
);
2323
};
2424

25-
export default MetadataQuery;
25+
export default DataQuery;

ui/src/custom-tabs/metadata-tab/MetadataTab.tsx renamed to ui/src/custom-tabs/data-tab/DataTab.tsx

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,20 @@ import {
1515
EuiTableRowCell,
1616
} from "@elastic/eui";
1717
import useLoadRegularFeatureView from "../../pages/feature-views/useLoadFeatureView";
18-
import MetadataQuery from "./MetadataQuery";
18+
import DataQuery from "./DataQuery";
1919

20-
const FeatureViewMetadataRow = z.object({
20+
const FeatureViewDataRow = z.object({
2121
name: z.string(),
2222
value: z.string(),
2323
});
2424

25-
type FeatureViewMetadataRowType = z.infer<typeof FeatureViewMetadataRow>;
25+
type FeatureViewDataRowType = z.infer<typeof FeatureViewDataRow>;
2626

2727
const LineHeightProp: React.CSSProperties = {
2828
lineHeight: 1,
2929
}
3030

31-
const EuiFeatureViewMetadataRow = ({name, value}: FeatureViewMetadataRowType) => {
31+
const EuiFeatureViewDataRow = ({name, value}: FeatureViewDataRowType) => {
3232
return (
3333
<EuiTableRow>
3434
<EuiTableRowCell>
@@ -45,11 +45,11 @@ const EuiFeatureViewMetadataRow = ({name, value}: FeatureViewMetadataRowType) =>
4545
);
4646
}
4747

48-
const FeatureViewMetadataTable = (data: any) => {
49-
var items: FeatureViewMetadataRowType[] = [];
48+
const FeatureViewDataTable = (data: any) => {
49+
var items: FeatureViewDataRowType[] = [];
5050

5151
for (let element in data.data){
52-
const row: FeatureViewMetadataRowType = {
52+
const row: FeatureViewDataRowType = {
5353
name: element,
5454
value: JSON.stringify(data.data[element], null, 2),
5555
};
@@ -61,22 +61,22 @@ const FeatureViewMetadataTable = (data: any) => {
6161
<EuiTable>
6262
<EuiTableHeader>
6363
<EuiTableHeaderCell>
64-
Metadata Item Name
64+
Data Item Name
6565
</EuiTableHeaderCell>
6666
<EuiTableHeaderCell>
67-
Metadata Item Value
67+
Data Item Value
6868
</EuiTableHeaderCell>
6969
</EuiTableHeader>
7070
{items.map((item) => {
71-
return <EuiFeatureViewMetadataRow name={item.name} value={item.value} />
71+
return <EuiFeatureViewDataRow name={item.name} value={item.value} />
7272
})}
7373
</EuiTable>
7474
)
7575
}
7676

77-
const MetadataTab = () => {
77+
const DataTab = () => {
7878
const fName = "credit_history"
79-
const { isLoading, isError, isSuccess, data } = MetadataQuery(fName);
79+
const { isLoading, isError, isSuccess, data } = DataQuery(fName);
8080
const isEmpty = data === undefined;
8181

8282
return (
@@ -97,7 +97,7 @@ const MetadataTab = () => {
9797
<h3>Properties</h3>
9898
</EuiTitle>
9999
<EuiHorizontalRule margin="xs" />
100-
<FeatureViewMetadataTable data={data} />
100+
<FeatureViewDataTable data={data} />
101101
</EuiPanel>
102102
</EuiFlexItem>
103103
</EuiFlexGroup>
@@ -107,4 +107,4 @@ const MetadataTab = () => {
107107
);
108108
};
109109

110-
export default MetadataTab;
110+
export default DataTab;

ui/src/index.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import FeastUI from "./FeastUI";
1515
// 3. Register the tab in the appropriate array below. Each entry
1616
// is a record with three keys: label, path, and Component.
1717
// Import your component and pass it as Component
18-
import MetadataTab from "./custom-tabs/metadata-tab/MetadataTab";
18+
import DataTab from "./custom-tabs/data-tab/DataTab";
1919
import RFVDemoCustomTab from "./custom-tabs/reguar-fv-demo-tab/DemoCustomTab";
2020
import ODFVDemoCustomTab from "./custom-tabs/ondemand-fv-demo-tab/DemoCustomTab";
2121
import FSDemoCustomTab from "./custom-tabs/feature-service-demo-tab/DemoCustomTab";
@@ -33,9 +33,9 @@ const tabsRegistry = {
3333
Component: RFVDemoCustomTab,
3434
},
3535
{
36-
label: "Metadata Tab Demo", // Navigation Label for the tab
37-
path: "metadata-tab", // Subpath for the tab
38-
Component: MetadataTab,
36+
label: "Data Tab Demo", // Navigation Label for the tab
37+
path: "data-tab", // Subpath for the tab
38+
Component: DataTab,
3939
},
4040
],
4141
OnDemandFeatureViewCustomTabs: [

ui/src/queries/useLoadFeatureViewSummaryStatistics.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const useLoadFeatureViewSummaryStatistics = (featureViewName: string) => {
99
const { projectName } = useParams();
1010

1111
const queryKey = `featureViewSummaryStatistics:${featureViewName}`;
12-
const url = `/metadata/${projectName}/featureView/${featureViewName}.json`;
12+
const url = `/data/${projectName}/featureView/${featureViewName}.json`;
1313

1414
return useQuery(
1515
queryKey,

0 commit comments

Comments
 (0)