Skip to content

Fix a runtime crash that could occur in minified native apps#7906

Merged
mrober merged 3 commits into
mainfrom
mrober/fixNdkKeepRules
Mar 13, 2026
Merged

Fix a runtime crash that could occur in minified native apps#7906
mrober merged 3 commits into
mainfrom
mrober/fixNdkKeepRules

Conversation

@mrober

@mrober mrober commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Fix Crashlytics NDK keep rules

This is based on cl/882058392

Tested manually in a local test app

This affects customers who use Crashlytics via the crashlytics.h file

@mrober mrober requested a review from tejasd March 13, 2026 17:06
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions

github-actions Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

tejasd
tejasd previously approved these changes Mar 13, 2026
Comment thread firebase-crashlytics-ndk/CHANGELOG.md Outdated
@mrober mrober enabled auto-merge (squash) March 13, 2026 17:59
@mrober mrober merged commit ada1257 into main Mar 13, 2026
28 checks passed
@mrober mrober deleted the mrober/fixNdkKeepRules branch March 13, 2026 18:02
@firebase firebase locked and limited conversation to collaborators Apr 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants