Detect changes in AB Testing (ABT) experiment metadata during config fetch#8002
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
athiramanu
requested review from
ashish-kothari,
dsjadaun-google and
tusharkhandelwal8
dsjadaun-google
approved these changes
Mar 31, 2026
tusharkhandelwal8
approved these changes
Apr 6, 2026
tusharkhandelwal8
previously approved these changes
Apr 6, 2026
tusharkhandelwal8
left a comment
tusharkhandelwal8
left a comment
Contributor
There was a problem hiding this comment.
Can we fix CI failures?
Updated to detect changes in AB Testing (ABT) experiment metadata. This ensures that if an experiment's variant or affected parameter keys change, the associated config keys are correctly identified as changed, even if the parameter values remain the same. Key changes: - Added constant to . - Implemented in to map affected config keys to their respective experiment descriptions. - Modified to compare experiment metadata for each config key. - Updated with cases for changed, deleted, and key-shifted experiments.
rlazo
reviewed
Apr 8, 2026
rlazo
requested changes
Apr 8, 2026
rlazo
approved these changes
Apr 10, 2026
emilypgoogle
added a commit
that referenced
this pull request
Apr 22, 2026
Adds daily test status to the Test Reporting bug. Unlike unit and instrumentation tests, all runs are always shown, since we currently only have 1 type of daily test. Example output below. ----- ### Unit Tests | | [#8009](#8009) | [#7983](#7983) | [#8002](#8002) | [#8027](#8027) | [#8028](#8028) | [#8025](#8025) | Success Rate | | :--- | :---: | :---: | :---: | :---: | :---: | :---: | :--- | | firebase-dataconnect | | | | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24202345424/job/70649528040) | | [⛔](https://github.com/firebase/firebase-android-sdk/actions/runs/24162429246/job/70516856982) | ⛔ 50% | *+8 passing SDKs ### Instrumentation Tests *All tests passing* ### Daily Tests | | Apr 15 | Apr 16 | Apr 17 | Apr 18 | Apr 19 | Apr 20 | Apr 21 | Success Rate | | :--- | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :--- | | AI Daily Tests | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24442505713) | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24498252859) | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24553833385) | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24599892175) | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24623963356) | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24654541730) | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24710324995) | ✅ 100% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to detect changes in AB Testing (ABT) experiment metadata. This ensures that if an experiment's variant or affected parameter keys change, the associated config keys are correctly identified as changed, even if the parameter values remain the same.
Key changes:
Validation:
Testing on sample Android app: Link