Conversation
Contributor
|
@bkendall FWIW I always choose the no-lint path. I find JS linters to be mostly annoying, but I am maybe in the minority. |
samtstern
approved these changes
Dec 11, 2020
joehan
reviewed
Dec 14, 2020
joehan
left a comment
joehan
left a comment
Member
There was a problem hiding this comment.
One issue, but otherwise this LGTM
| "name": "functions", | ||
| "scripts": { | ||
| "lint": "eslint \"src/**/*\"", | ||
| "lint": "eslint --ext .js,.ts .", |
Member
There was a problem hiding this comment.
Will this cause eslint to lint compiled js files? I think we don't want that.
Contributor
There was a problem hiding this comment.
@joehan I don't think it would, as JS files (apart from .eslintrc.js) are listed in the .gitignore
Contributor
Author
There was a problem hiding this comment.
(I've been working on coming back to this but @hithomasmorelli is correct)
joehan
approved these changes
Jan 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tsconfig.dev.jsonto the TS+eslint path to appropriately lint.eslintrc.js.Fixes #2913
As an aside: I wouldn't be opposed to simplifying this further and not offering the no-lint path. Also, we don't have any script for
npm test, so there's nothing blocking about always including lint (except your IDE might start flagging issues sooner). Food for thought...Scenarios Tested
Sample Commands
firebase init functions