Skip to content

Add root: true to eslintrc#2925

Closed
hubgit wants to merge 1 commit into
firebase:masterfrom
hubgit:patch-1
Closed

Add root: true to eslintrc#2925
hubgit wants to merge 1 commit into
firebase:masterfrom
hubgit:patch-1

Conversation

@hubgit

@hubgit hubgit commented Dec 12, 2020

Copy link
Copy Markdown
Contributor

Set root: true in the .eslintrc template, so that ESLint doesn't try to combine the configuration in the functions directory with the configuration in an .eslintrc file in the parent app directory.

Set `root: true` in the .eslintrc template, so that ESLint doesn't try to combine the configuration in the `functions` directory with the configuration in an `.eslintrc` file in the parent app directory.
@google-cla

google-cla Bot commented Dec 12, 2020

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label Dec 12, 2020
@hubgit

hubgit commented Dec 12, 2020

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes Manual indication that this has passed CLA. and removed cla: no labels Dec 12, 2020
@samtstern samtstern requested a review from bkendall December 14, 2020 11:41
@samtstern

Copy link
Copy Markdown
Contributor

@hubgit thanks for the contribution! Assigning to @bkendall who is our lint master.

@bkendall

bkendall commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

Sorry for being super delayed. I like this idea, but could you update this branch with master and then update both _eslintrc files (which were just updated to be a bit more simple) to include this change? Thanks!

@bkendall

Copy link
Copy Markdown
Contributor

Taking the idea and running with it (keeping your initial commit) in #3029. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants