Prevent pinTags + minInstances from any functions, not just frameworks#6684
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6684 +/- ##
==========================================
- Coverage 54.18% 54.18% -0.01%
==========================================
Files 347 347
Lines 24130 24132 +2
Branches 4976 4977 +1
==========================================
Hits 13075 13075
- Misses 9855 9856 +1
- Partials 1200 1201 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@inlined so how can I use minInstances for my webframework deployment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously removed pinTags from the web frameworks configuration options because it is a foot gun, but customers could still hurt themselves if they turn on pinTags with a manual Function rewrite. This prevents the footgun at the API layer.