Change from GET to POST to fix 414 issue

ethanchewy · ethanchewy · commit a11cb93f0f55 · 2018-09-21T14:34:03.000-07:00
diff --git a/app.py b/app.py
@@ -34,7 +34,7 @@ def index():
     session["time_now"] = datetime.now()
     return render_template("index.html")
 
-@app.route('/check_code')
+@app.route('/check_code', methods=['POST'])
 def check_code():
     """Run pylint on code and get output
         :return: JSON object of pylint errors
@@ -53,7 +53,7 @@ def check_code():
         https://github.com/PyCQA/pylint/blob/master/pylint/lint.py
     """
     #Get textarea text from AJAX call
-    text = request.args.get('text')
+    text = request.form['text']
 
     # Session to handle multiple users at one time
     session["code"] = text
diff --git a/static/js/cm-validator-remote.js b/static/js/cm-validator-remote.js
@@ -13,7 +13,6 @@ CodeMirror.remoteValidator = function(cm, updateLinting, options) {
 	{
 		var found = [];
 
-		console.log(error_list);
 		for(var i in error_list)
 		{
 			var error = error_list[i];
@@ -53,7 +52,7 @@ CodeMirror.remoteValidator = function(cm, updateLinting, options) {
 				});
 			}
 		}
-		
+
 		updateLinting(cm, found);
 	}
 
diff --git a/static/js/javascript.js b/static/js/javascript.js
@@ -85,7 +85,7 @@ $(document).ready(function(){
 
 		}
 		//AJAX call to pylint
-		$.getJSON('/check_code', {
+		$.post('/check_code', {
 	      text :  code
 	    }, function(data) {
 	    	current_text = data;
@@ -114,7 +114,7 @@ $(document).ready(function(){
 
     //Actually Run in Python
 	$( "#run" ).click(function() {
-		$.getJSON('/run_code', {
+		$.post('/run_code', {
 	      text :  editor.getValue()
 	    }, function(data) {
 	    	print_result(data);
@@ -125,7 +125,7 @@ $(document).ready(function(){
 	    	document.getElementById('output').innerHTML = '';
 	    	$("#output").append("<pre>"+data+"</pre>");
 	    }
-	});
+	}, "json");
 	var exampleCode = function (id, text) {
         $(id).click(function (e) {
             editor.setValue(text);

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,6 @@ CodeMirror.remoteValidator = function(cm, updateLinting, options) {`
`13`	`13`	`{`
`14`	`14`	`var found = [];`
`15`	`15`
`16`		`- console.log(error_list);`
`17`	`16`	`for(var i in error_list)`
`18`	`17`	`{`
`19`	`18`	`var error = error_list[i];`
`@@ -53,7 +52,7 @@ CodeMirror.remoteValidator = function(cm, updateLinting, options) {`
`53`	`52`	`});`
`54`	`53`	`}`
`55`	`54`	`}`
`56`		`-`
	`55`	`+`
`57`	`56`	`updateLinting(cm, found);`
`58`	`57`	`}`
`59`	`58`