Skip to content

Commit 3e75fb5

Browse files
trmquang93cameroncooke
authored andcommitted
Fix build_device next step suggesting unsupported --device-id flag (#287)
The list_devices tool included deviceId in nextStepParams for build_device, but build_device does not accept a deviceId parameter (it builds generically for the iOS device platform). This caused the CLI to render an invalid suggestion like: xcodebuildmcp device build --device-id "DEVICE_UDID" Remove deviceId from build_device's nextStepParams. The build_run_device and test_device entries correctly retain deviceId since those tools require it.
1 parent 937b19d commit 3e75fb5

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/mcp/tools/device/__tests__/list_devices.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ describe('list_devices plugin (device-shared)', () => {
217217
expect(text).toContain('Test iPhone');
218218
expect(text).toContain('test-device-123');
219219
expect(result.nextStepParams).toEqual({
220-
build_device: { scheme: 'YOUR_SCHEME', deviceId: 'UUID_FROM_ABOVE' },
220+
build_device: { scheme: 'YOUR_SCHEME' },
221221
install_app_device: { deviceId: 'UUID_FROM_ABOVE', appPath: 'PATH_TO_APP' },
222222
});
223223
});

src/mcp/tools/device/list_devices.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ type ListDevicesParams = z.infer<typeof listDevicesSchema>;
1818
type ListDevicesResult = DeviceListDomainResult;
1919

2020
const NEXT_STEP_PARAMS = {
21-
build_device: { scheme: 'YOUR_SCHEME', deviceId: 'UUID_FROM_ABOVE' },
21+
build_device: { scheme: 'YOUR_SCHEME' },
2222
install_app_device: { deviceId: 'UUID_FROM_ABOVE', appPath: 'PATH_TO_APP' },
2323
} as const;
2424

0 commit comments

Comments
 (0)