Skip to content

fix(bigquery): move MaxStaleness field to table level#10066

Merged
alvarowolfx merged 5 commits into
googleapis:mainfrom
alvarowolfx:bq-fix-max-staleness
Feb 3, 2025
Merged

fix(bigquery): move MaxStaleness field to table level#10066
alvarowolfx merged 5 commits into
googleapis:mainfrom
alvarowolfx:bq-fix-max-staleness

Conversation

@alvarowolfx

@alvarowolfx alvarowolfx commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

Sounds like updating MaxStaleness is not working, so an internal ticket was opened to check that part.

Fixes #10026

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Apr 30, 2024
@alvarowolfx alvarowolfx requested a review from shollyman April 30, 2024 15:15

@shollyman shollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general looks reasonable, but I'd like more details on what the table level field may actually control.

Comment thread bigquery/table.go Outdated
@codyoss

codyoss commented Dec 10, 2024

Copy link
Copy Markdown
Member

@alvarowolfx is this still active or can this be closed?

@alvarowolfx

Copy link
Copy Markdown
Contributor Author

still blocked by internal b/338036701. Will reopen when it's done.

@alvarowolfx alvarowolfx reopened this Feb 3, 2025
@alvarowolfx alvarowolfx marked this pull request as ready for review February 3, 2025 18:39
@alvarowolfx alvarowolfx requested review from a team and suzmue February 3, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bigquery: max staleness cannot be retreived/updated

3 participants