docs(pubsub): MinExtensionPeriod defaults to 60 seconds#10791
Merged
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
azurda
changed the title
codyoss
changed the title
hongalex
approved these changes
Nov 12, 2024
hongalex
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment in the documentation is confusing.
From what I read through the code:
google-cloud-go/pubsub/iterator.go
Line 62 in 897539d
minDurationPerLeaseExtensionExactlyOnceis set to 60 secondsand if
exactlyOnceit calls maxDuration which sets it to indeed 60 sgoogle-cloud-go/pubsub/iterator.go
Line 948 in 897539d