feat(pubsub): support payload wrapping for push subs#8292
Merged
Conversation
product-auto-label
Bot
added
size: m
ORabbit
approved these changes
Jul 20, 2023
| if ps.PushConfig == nil { | ||
| ps.PushConfig = &pb.PushConfig{} | ||
| } else if ps.PushConfig.Wrapper == nil { | ||
| // Wrapper should default to PubsubWrapper. |
There was a problem hiding this comment.
Defaulting to nil is also acceptable and is treated as PubsubWrapper.
Member
Author
There was a problem hiding this comment.
This is just implementing that behavior in the fake server we provide. The client doesn't know about the default and should default to nil
shollyman
approved these changes
Jul 20, 2023
shollyman
left a comment
shollyman
left a comment
Contributor
There was a problem hiding this comment.
It's times like this I wish oneof yielded a proto type we could embed, but the isWrapper() interface seems sufficient here.
noahdietz
approved these changes
Jul 24, 2023
noahdietz
left a comment
noahdietz
left a comment
Contributor
There was a problem hiding this comment.
Stamp for vet.sh change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the new payload unwrapping feature to the handwritten admin client.
Docs here: https://cloud.google.com/pubsub/docs/payload-unwrapping
Changes to
vet.share because includingpubsub.PubsubWrapperis intentional. PubsubWrapper is the name included in the proto. The alternative would be defining it aspubsub.PushConfigPubsubWrapperwhich seems perhaps more verbose and inconsistent with what we've already been doing (like with pubsub.OIDCToken)[https://pkg.go.dev/cloud.google.com/go/pubsub#OIDCToken]