feat(pubsub): support publisher compression#9711
Merged
Merged
Conversation
alvarowolfx
approved these changes
Apr 10, 2024
alvarowolfx
left a comment
alvarowolfx
left a comment
Contributor
There was a problem hiding this comment.
I think it looks good to me feature wise, but I added a comment on how to improve the call to .Publish to avoid having two code paths calling it.
alvarowolfx
approved these changes
Apr 29, 2024
ma-g-22
pushed a commit
to ma-g-22/google-cloud-go
that referenced
this pull request
Apr 29, 2024
* feat(pubsub): support publisher compression * address review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to Java, this PR adds gRPC compression support to the
Publishmethod specifically.This does not add change the number of bytes that Pub/Sub charges for, as it is compressed and decompressed in transit. Currently, only gzip is supported.
internal issue: 226594738