fix: Fix error handling to extract error information from the response body (#738)

MarkDuckworth · web-flow · commit ba456776f3f2 · 2025-09-19T14:39:06.000-04:00
* Fix error handling to process response body

* lint

* Test for passing API error messages in GaxiosError message property
diff --git a/core/packages/gaxios/src/gaxios.ts b/core/packages/gaxios/src/gaxios.ts
@@ -196,11 +196,11 @@ export class Gaxios implements FetchCompliance {
         if (opts.responseType === 'stream') {
           const response = [];
 
-          for await (const chunk of (opts.data ?? []) as Readable) {
+          for await (const chunk of translatedResponse.data as Readable) {
             response.push(chunk);
           }
 
-          translatedResponse.data = response as T;
+          translatedResponse.data = response.toString() as T;
         }
 
         const errorInfo = GaxiosError.extractAPIErrorFromResponse(
diff --git a/core/packages/gaxios/test/test.getch.ts b/core/packages/gaxios/test/test.getch.ts
@@ -113,6 +113,36 @@ describe('🚙 error handling', () => {
     );
   });
 
+  it('should handle AIP-193 error bodies: passes API error in message', async () => {
+    const body = {
+      error: {
+        code: 429,
+        message:
+          "The zone 'us-east1-a' does not have enough resources available to fulfill the request. Try a different zone, or try again later.",
+        status: 'RESOURCE_EXHAUSTED',
+        details: [],
+      },
+    };
+    const readableStream = Readable.from(JSON.stringify(body));
+    const scope = nock(url).get('/').reply(429, readableStream);
+
+    await assert.rejects(
+      request<ArrayBuffer>({url, responseType: 'stream'}),
+      (err: GaxiosError) => {
+        scope.done();
+        const apiError = JSON.parse(err.message);
+        return (
+          apiError.error.code === 429 &&
+          apiError.error.message ===
+            "The zone 'us-east1-a' does not have enough resources available to fulfill the request. Try a different zone, or try again later." &&
+          apiError.error.status === 'RESOURCE_EXHAUSTED' &&
+          Array.isArray(apiError.error.details) &&
+          apiError.error.details.length === 0
+        );
+      },
+    );
+  });
+
   it('should not throw an error during a translation error', () => {
     const notJSON = '.';
     const response = {

Original file line number	Diff line number	Diff line change
`@@ -196,11 +196,11 @@ export class Gaxios implements FetchCompliance {`
`196`	`196`	`if (opts.responseType === 'stream') {`
`197`	`197`	`const response = [];`
`198`	`198`
`199`		`- for await (const chunk of (opts.data ?? []) as Readable) {`
	`199`	`+ for await (const chunk of translatedResponse.data as Readable) {`
`200`	`200`	`response.push(chunk);`
`201`	`201`	`}`
`202`	`202`
`203`		`- translatedResponse.data = response as T;`
	`203`	`+ translatedResponse.data = response.toString() as T;`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`const errorInfo = GaxiosError.extractAPIErrorFromResponse(`