This repository was archived by the owner on Mar 17, 2026. It is now read-only.
fix: updated span kind to CLIENT for ack and modack rpc spans#2029
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
Bot
added
size: m
2 tasks
Collaborator
|
@bizob2828 Thanks for the PR! Let me run this by my OTel collaborator here. |
feywind
previously approved these changes
May 8, 2025
feywind
changed the title
Collaborator
|
@bizob2828 Hey would you mind running |
Contributor
Author
|
@feywind I ran |
hongalex
previously approved these changes
Sep 9, 2025
feywind
previously approved these changes
Sep 9, 2025
…ook at that in a separate PR if it's problematic
feywind
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
leahecole
approved these changes
Oct 1, 2025
feywind
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2028 🦕
This PR updates the span kind based on the unary pull example to set span kind to client for modack/ack spans. I also added some missing assertions from #2019