Skip to content

Commit f88590f

Browse files
author
Prachi Damle
committed
CLOUDSTACK-3218: AWSAPI - For runInstances, awsapi need not send networkId information in case of advance zone
Changes: awsapi will not pass networkId in case of Advance Zone and let CS identify which network to deploy VM in. The same case applies to allocateAddress API too.
1 parent 4bbc65b commit f88590f

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -849,9 +849,9 @@ public EC2Address allocateAddress() {
849849
CloudStackAccount caller = getCurrentAccount();
850850

851851
CloudStackZone zone = findZone();
852-
CloudStackNetwork net = findNetwork(zone);
852+
//CloudStackNetwork net = findNetwork(zone);
853853
// CloudStackIpAddress resp = getApi().associateIpAddress(null, null, null, "0036952d-48df-4422-9fd0-94b0885e18cb");
854-
CloudStackIpAddress resp = getApi().associateIpAddress(zone.getId(), caller.getName(), caller.getDomainId(), net != null ? net.getId():null);
854+
CloudStackIpAddress resp = getApi().associateIpAddress(zone.getId(), caller.getName(), caller.getDomainId(), null);
855855
ec2Address.setAssociatedInstanceId(resp.getId());
856856

857857
if (resp.getIpAddress() == null) {
@@ -1399,14 +1399,14 @@ public EC2RunInstancesResponse runInstances(EC2RunInstances request) {
13991399
CloudStackZone zone = zones.get(0);
14001400

14011401
// network
1402-
CloudStackNetwork network = findNetwork(zone);
1402+
//CloudStackNetwork network = findNetwork(zone);
14031403

14041404
// now actually deploy the vms
14051405
for( int i=0; i < createInstances; i++ ) {
14061406
try{
14071407
CloudStackUserVm resp = getApi().deployVirtualMachine(svcOffering.getId(),
1408-
request.getTemplateId(), zoneId, null, null, null, null,
1409-
null, null, null, request.getKeyName(), null, (network != null ? network.getId() : null),
1408+
request.getTemplateId(), zoneId, null, null, null, null,
1409+
null, null, null, request.getKeyName(), null, null,
14101410
null, constructList(request.getGroupSet()), request.getSize().longValue(), request.getUserData());
14111411
EC2Instance vm = new EC2Instance();
14121412
vm.setId(resp.getId().toString());

0 commit comments

Comments
 (0)