[[ Constify ]] Ensure extern refs to tables have const modifier

livecodeali · livecodeali · commit a1dd39cd68a1 · 2017-08-10T12:39:37.000+01:00
diff --git a/engine/src/exec-engine.cpp b/engine/src/exec-engine.cpp
@@ -236,11 +236,11 @@ MCExecSetTypeInfo *kMCEngineSecurityCategoriesTypeInfo = &_kMCEngineSecurityCate
 
 ////////////////////////////////////////////////////////////////////////////////
 
-extern LT command_table[];
+extern const LT command_table[];
 extern const uint4 command_table_size;
-extern Cvalue constant_table[];
+extern const Cvalue constant_table[];
 extern const uint4 constant_table_size;
-extern LT factor_table[];
+extern const LT factor_table[];
 extern const uint4 factor_table_size;
 
 ////////////////////////////////////////////////////////////////////////////////
diff --git a/engine/src/widget.cpp b/engine/src/widget.cpp
@@ -353,7 +353,7 @@ void MCWidget::recompute(void)
 
 static void lookup_name_for_prop(Properties p_which, MCNameRef& r_name)
 {
-    extern LT factor_table[];
+    extern const LT factor_table[];
     extern const uint4 factor_table_size;
     for(uindex_t i = 0; i < factor_table_size; i++)
         if (factor_table[i] . type == TT_PROPERTY && factor_table[i] . which == p_which)
diff --git a/engine/test/test_lextable.cpp b/engine/test/test_lextable.cpp
@@ -25,7 +25,7 @@ TEST(lextable, constant_table)
 // Checks that the entries of constant_table are in alphabetical order.
 //
 {
-	extern Cvalue constant_table[];
+	extern const Cvalue constant_table[];
 	extern const uint4 constant_table_size;
 
 	ASSERT_GE(constant_table_size, (unsigned)1);
@@ -44,10 +44,10 @@ TEST(lextable, table_pointer)
 // Checks that the entries of factor_table are in alphabetical order.
 //
 {
-	extern LT *table_pointers[];
+	extern const LT *table_pointers[];
 	extern const uint4 table_pointers_size;
 
-	extern uint2 table_sizes[];
+	extern const uint2 table_sizes[];
 	extern const uint4 table_sizes_size;
 
 	ASSERT_EQ(table_pointers_size, table_sizes_size);

Original file line number	Diff line number	Diff line change
`@@ -353,7 +353,7 @@ void MCWidget::recompute(void)`
`353`	`353`
`354`	`354`	`static void lookup_name_for_prop(Properties p_which, MCNameRef& r_name)`
`355`	`355`	`{`
`356`		`- extern LT factor_table[];`
	`356`	`+ extern const LT factor_table[];`
`357`	`357`	`extern const uint4 factor_table_size;`
`358`	`358`	`for(uindex_t i = 0; i < factor_table_size; i++)`
`359`	`359`	`if (factor_table[i] . type == TT_PROPERTY && factor_table[i] . which == p_which)`