Skip to content

Commit b5071f2

Browse files
samueliggregkh
authored andcommitted
ipack/devices/ipoctal: setup TTY_NORMAL flag for each character.
In case of several characters present in RxFIFO, they will have the flag of the previous one, no matter if the actual character was received properly or not. This patch fixes this bug. Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a1da13a commit b5071f2

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/ipack/devices/ipoctal.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,11 +121,12 @@ static void ipoctal_irq_rx(struct ipoctal_channel *channel,
121121
struct tty_struct *tty, u8 sr)
122122
{
123123
unsigned char value;
124-
unsigned char flag = TTY_NORMAL;
124+
unsigned char flag;
125125
u8 isr;
126126

127127
do {
128128
value = ioread8(&channel->regs->r.rhr);
129+
flag = TTY_NORMAL;
129130
/* Error: count statistics */
130131
if (sr & SR_ERROR) {
131132
iowrite8(CR_CMD_RESET_ERR_STATUS, &channel->regs->w.cr);

0 commit comments

Comments
 (0)