[[ Bug 19994 ]] Clear substacks in destroystack

montegoulding · montegoulding · commit 6f92ae81f5c0 · 2017-07-04T11:46:40.000+10:00
Prevously substacks were not being cleared correctly when the
startup stack was destroyed and therefore substacks that were
referenced were not cleanly removed.
diff --git a/docs/notes/bugfix-19994.md b/docs/notes/bugfix-19994.md
@@ -0,0 +1 @@
+# Ensure startup stack substacks are cleanly removed from memory
diff --git a/engine/src/dispatch.cpp b/engine/src/dispatch.cpp
@@ -363,6 +363,12 @@ void MCDispatch::destroystack(MCStack *sptr, Boolean needremove)
 {
 	if (needremove)
     {
+        MCStack *t_substacks = sptr -> getsubstacks();
+        while (t_substacks)
+        {
+            t_substacks -> dodel();
+            t_substacks = sptr -> getsubstacks();
+        }
         sptr -> dodel();
     }
 	if (sptr == MCstaticdefaultstackptr)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Ensure startup stack substacks are cleanly removed from memory`
Original file line number	Diff line number	Diff line change
`@@ -363,6 +363,12 @@ void MCDispatch::destroystack(MCStack *sptr, Boolean needremove)`
`363`	`363`	`{`
`364`	`364`	`if (needremove)`
`365`	`365`	`{`
	`366`	`+ MCStack *t_substacks = sptr -> getsubstacks();`
	`367`	`+ while (t_substacks)`
	`368`	`+ {`
	`369`	`+ t_substacks -> dodel();`
	`370`	`+ t_substacks = sptr -> getsubstacks();`
	`371`	`+ }`
`366`	`372`	`sptr -> dodel();`
`367`	`373`	`}`
`368`	`374`	`if (sptr == MCstaticdefaultstackptr)`