now using optional and is_optional to check for non optional parameters after optional ones also resolved a typo \t\bool instead of \t\tbool

Monte Goulding · Monte Goulding · commit e32fd9f79ea8 · 2013-06-09T18:11:49.000+10:00
diff --git a/lcidlc/src/Interface.cpp b/lcidlc/src/Interface.cpp
@@ -420,9 +420,9 @@ bool InterfaceDefineHandlerParameter(InterfaceRef self, Position p_where, Parame
 		}
 		
 	// RULE: No non-optional parameters after an optional one
-	if (optional &&
+	if (!optional &&
 		t_variant -> parameter_count > 0 &&
-		t_variant -> parameters[t_variant -> parameter_count - 1] . default_value != nil)
+		t_variant -> parameters[t_variant -> parameter_count - 1] . is_optional)
 		InterfaceReport(self, p_where, kInterfaceErrorParamAfterOptionalParam, nil);
 	
 	if (!MCMemoryResizeArray(t_variant -> parameter_count + 1, t_variant -> parameters, t_variant -> parameter_count))
diff --git a/lcidlc/src/InterfaceGenerate.cpp b/lcidlc/src/InterfaceGenerate.cpp
@@ -860,7 +860,7 @@ static bool InterfaceGenerateHandlers(InterfaceRef self, CoderRef p_coder)
 						if (t_native_type != kNativeTypeEnum)
 							CoderWriteLine(p_coder, "\t\tbool t_fetched = fetch__%s(\"%s\", argv[%d], param__%s);", NativeTypeGetTag(t_native_type), t_name, k, t_name);
 						else
-							CoderWriteLine(p_coder, "\t\bool t_fetched = fetchenum__%s(\"%s\", argv[%d], param__%s);", name_to_cname(t_parameter -> type), t_name, k, t_name);
+							CoderWriteLine(p_coder, "\t\tbool t_fetched = fetchenum__%s(\"%s\", argv[%d], param__%s);", name_to_cname(t_parameter -> type), t_name, k, t_name);
                         // optional parameters without a default value
                         if (!t_parameter->is_optional)
                             CoderWriteLine(p_coder, "\t\tsuccess = t_fetched;");
