String concatenation cleanup

K0zka · K0zka · commit 74a3cb4d5ec2 · 2014-02-09T19:01:45.000+01:00
Replaced string concatenation in loop with StringBuilder

Signed-off-by: Laszlo Hornyak &lt;laszlo.hornyak@gmail.com&gt;
diff --git a/plugins/hypervisors/kvm/src/org/apache/cloudstack/utils/qemu/QemuImg.java b/plugins/hypervisors/kvm/src/org/apache/cloudstack/utils/qemu/QemuImg.java
@@ -90,11 +90,11 @@ public void create(QemuImgFile file, QemuImgFile backingFile, Map<String, String
 
         if (options != null && !options.isEmpty()) {
             s.add("-o");
-            String optionsStr = "";
+            final StringBuilder optionsStr = new StringBuilder();
             for (Map.Entry<String, String> option : options.entrySet()) {
-                optionsStr += option.getKey() + "=" + option.getValue() + ",";
+                optionsStr.append(option.getKey()).append('=').append(option.getValue()).append(',');
             }
-            s.add(optionsStr);
+            s.add(optionsStr.toString());
         }
 
         /*

Original file line number	Diff line number	Diff line change
`@@ -90,11 +90,11 @@ public void create(QemuImgFile file, QemuImgFile backingFile, Map<String, String`
`90`	`90`
`91`	`91`	`if (options != null && !options.isEmpty()) {`
`92`	`92`	`s.add("-o");`
`93`		`- String optionsStr = "";`
	`93`	`+ final StringBuilder optionsStr = new StringBuilder();`
`94`	`94`	`for (Map.Entry<String, String> option : options.entrySet()) {`
`95`		`- optionsStr += option.getKey() + "=" + option.getValue() + ",";`
	`95`	`+ optionsStr.append(option.getKey()).append('=').append(option.getValue()).append(',');`
`96`	`96`	`}`
`97`		`- s.add(optionsStr);`
	`97`	`+ s.add(optionsStr.toString());`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`/*`