Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openstack/charm-openstack-dashboard
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: openstack/charm-openstack-dashboard
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: stable/zed
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 50 files changed
  • 9 contributors

Commits on Oct 21, 2022

  1. Updates for zed stable branch creation

    - Set default branch for git review/gerrit to stable/zed
    - Switch tests to stable.
    - Switch to using stable charm-helpers branch.
    - Switch to using stable charm.openstack branch.
    - Switch to using stable zaza, zaza-openstack-tests
      branch
    - (reactive charms) Add build.lock file
    - (classic charms) make sync
    - (reactive: not reactive plugin): lock charm-tools < 3.1
    - (reactive: with reactive plugin): lock charm snap to 3.x/stable
    
    Change-Id: I15d6662d536704eb15d8b64698bda559bdb02b8f
    ajkavanagh authored and wolsen committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    0b4d640 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Pin tox to < 4.0.0

    Tox 4.0.0 was recently released and it has several breaking changes.
    We pin to < 4.0.0 here. We are planning to move forward only on the
    master charm branches.
    
    Tox is also pinned to < 4.0.0 for stable branches in upstream
    openstack-zuul-jobs as well as in zosci-config. However, the
    requires= section in the charm's tox.ini file ends up installing
    tox>4, wiping out the zuul-pinned tox<4 that was already installed
    installed. This patch fixes that.
    
    Change-Id: I63617e671dbf1ffdba19d17f1a9d18269b558c91
    Corey Bryant committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    7cb1d9f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Make LocalSettingsContext more robust to priority

    The relation data for for the LocalSettings context could cause the
    priority sorting to break if the priority key wasn't cmpable (e.g. using
    <, > or ==).  This patch fixes the associated bug, by making the sorting
    extra robust and ensuring that un-cmp-able values are 'greater' (e.g.
    further down the list) that cmp-able values, and equal to each other.
    E.g. a partially ordered set.
    
    This change also pins jsonschema in test-requirements.txt to fix
    py310 failures due to newer versions of jsonschema pulling in rpds-py
    and therefore the Rust toolchain.
    
    Change-Id: I6bbf7e5f81a772ffc6ea859c9ab7c05f2eb9fdc5
    Closes-bug: #2023404
    (cherry picked from commit e8d0ca3)
    ajkavanagh authored and Corey Bryant committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    4bb148c View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. [zed] Ensure get_requests_for_local_unit doesn't fail on incomplete r…

    …elation
    
    This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix
    any inadvertant accesses of ['ca'] in the relation data before it is available
    from vault in the certificates relation.  Fix in charmhelpers is in [1].
    
    [1] juju/charm-helpers#826
    Closes-Bug: #2028683
    
    Change-Id: I484443c470efe4d3cd89f5b6527576fea7414a03
    ajkavanagh committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    dc5f4be View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Add new interface 'dashboard'

    openstack-dashboard exposes the hostnames (and IP addresses) that can be
    used by users to load Horizon. There are 3 possible sources, they are
    juju units ingress-address, os-public-hostname and vip config options
    
    Closes-Bug: #2030094
    Change-Id: I5eb524c6258f72980ef43175f2bed21d7ca078be
    (cherry picked from commit 484b7d8)
    freyes committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    eab473e View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Support disabling apache wsgi socket rotation

    Bug LP 1863232 introduced a new Apache configuration option called
    WSGISocketRotation which allows users to disable wsgi socket
    rotation. This patch makes this configurable with a new
    wsgi-socket-rotation config option that defaults to the Apache
    default and can optionally be set to False.
    
    Closes-Bug: #2021550
    Change-Id: Ic89feaf34f6f9060fa1fde4a9dacb7446dd7b532
    zhhuabj committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    d0d0f0f View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Run relation_set() in dashboard_relation_changed() on leader

    The commit 484b7d8 introduced a new relation that relies on an
    application databag to exchange data, although only the leader can write
    to it, and the original patch didn't guard the relation_set() call with
    a is_leader(), this patch addresses that problem wich produces a hook
    failure on follower units when openstack-dashboard is deployed in HA.
    
    Closes-Bug: #2046257
    Related-Bug: #2030094
    Change-Id: I1930b0b96f65cb627f896db67dddc6370cf6a413
    (cherry picked from commit 4d55814)
    freyes committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    617fbcc View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Allow configure of OPENSTACK_INSTANCE_RETRIEVE_IP_ADDRESSES

    If network calls to retrieve ports and floating IPs take too long,
    then the project > instances page cannot be loaded. This config
    allows disabling the network calls when loading the page with
    minor side-effects, as a workaround to avoid downtime while other
    performance optimizations can be done on the side to allow
    the page the load so the workaround is no longer needed.
    
    Closes-bug: #2051003
    Related-bug: #2045168
    Change-Id: Iedad6ef48cbe0b776594f4ad8276d3d713cd360c
    (cherry picked from commit 6b93e9d)
    (cherry picked from commit 45a86be)
    (cherry picked from commit 1ec179b)
    rodrigogansobarbieri authored and Rodrigo Barbieri committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    9e2ae8e View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Adjust haproxy timeout to intended values

    Many years ago change Ida7949113594b9b859ab7b4ba8b2bb440bab6e7d
    attempted to change the timeouts of haproxy but did not succeed,
    as deployments were still using the values from the charm's
    templates/haproxy.cfg file, being effectively set to 30 seconds
    and causing timeouts (see bug). Additionally, the description
    of the config options became inaccurate, stating the default to
    be a value that they were really not.
    
    This patch addresses the timeout value discrepancy, adjusting
    to the original change's intended values.
    
    Closes-bug: #2045168
    Change-Id: I83405727b4a116ec6f47b61211bf8ef3d2d9fbd6
    (cherry picked from commit 09c5871)
    (cherry picked from commit 2f430d1)
    (cherry picked from commit f013b18)
    rodrigogansobarbieri authored and Rodrigo Barbieri committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    f6f60a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Set X-Frame-Options header to sameorigin

    If this header is set to deny, then operations cannot be performed from
    the network topology page as the <svg> tag is a kind of <embed> and
    access is restricted from there. Setting it to sameorigin allows
    operations from the network topology page as long as they belong to the
    same web application (same origin).
    Related-Bug: #2077024
    
    Change-Id: Ifcc9725bad34178a3eb606e9f822d2a68f5bf987
    (cherry picked from commit ef031d4)
    drencrom committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    57ba7e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Set X-Frame-Options header to sameorigin for https

    If this header is set to deny, then operations cannot be performed from
    the network topology page as the <svg> tag is a kind of <embed> and
    access is restricted from there. This was previously set only for the
    HTTP virtual host (commit ef031d4). This patch adds the same
    configuration for HTTPS.
    
    Closes-Bug: #2077024
    
    Change-Id: I9b0819890750391d1980c4d1ee9c171ba6d38c8b
    (cherry picked from commit 0f5fc5e)
    drencrom committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    60b1295 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2025

  1. Fix missing create/delete role buttons

    The frontend create/delete role buttons on
    Identity>Roles page rely on a backend config
    OPENSTACK_KEYSTONE_BACKEND that is defined in
    the config file. However, the setting is not being
    returned to the frontend because there is another
    setting called REST_API_REQUIRED_SETTINGS that lists
    the settings that are returned to the frontend.
    
    This patch adds OPENSTACK_KEYSTONE_BACKEND to
    REST_API_REQUIRED_SETTINGS which was also done upstream
    on commit 9c19b07 back in 2019.
    
    Closes-bug: #2056377
    Change-Id: Ia8a18e66610f7149399fe1614b1e515ecf799f55
    (cherry picked from commit 2f52ca2)
    Rodrigo Barbieri committed Apr 8, 2025
    Configuration menu
    Copy the full SHA
    35cce5d View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2025

  1. Change flag for enabling secure cookies

    Secure cookies where enabled on the local_settings.py template by the
    flag ssl_configured that was not set anywhere. Setting now that flag on
    the ApacheSSLContext class.
    
    Closes-Bug: #2118778
    
    Change-Id: Ic73b1a6a878efae126c87764d2a26afbfce4d740
    Signed-off-by: Jorge Merlino <jorge.merlino@canonical.com>
    (cherry picked from commit 2c43ae4)
    drencrom committed Oct 6, 2025
    Configuration menu
    Copy the full SHA
    893dc75 View commit details
    Browse the repository at this point in the history
  2. Add support for Content-Security-Policy header

    Adding a configuration parameter csp-options that, when set, adds a
    Content-Security-Policy header to the apache configuration.
    This header can prevent or minimize the risk of certain types of
    security threats by placing restrictions on the things the web page's
    code can do.
    
    Closes-Bug: #2118835
    
    Change-Id: I06f0b1c2787fa56460e5a196d3ca07c0a85c14e3
    Signed-off-by: Jorge Merlino <jorge.merlino@canonical.com>
    (cherry picked from commit 41250d9)
    drencrom committed Oct 6, 2025
    Configuration menu
    Copy the full SHA
    e8b1753 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2025

  1. Configuration menu
    Copy the full SHA
    2d82e8c View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2026

  1. Remove form-action 'self' from CSP default configuration

    This setting breaks Single Sign On as it prevents the forms to submit to
    an external site, which is exactly what the login form does when SSO is
    enabled.
    
    Closes-Bug: #2138262
    Change-Id: Ia0e9df362b1ccc4c797a6cfe0f6d10a660f7c924
    Signed-off-by: Jorge Merlino <jorge.merlino@canonical.com>
    (cherry picked from commit 40a8e74)
    drencrom committed Feb 3, 2026
    Configuration menu
    Copy the full SHA
    180b36f View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2026

  1. Cleanup Zed CI

    * update:
      - charmcraft.yaml for v3
      - tox.ini to use py3.10 by default
      - test-requirements.in to use zaza for juju3
      - update test bundles to work with charmcraft v3
    * generate:
      - merged-requirements-py310.txt
      - test-requirements-py310.txt
    * add:
       - update-requirements env to tox.ini
    * .zuul.yaml:
      - switch to charm jobs to get py310 support
    
    Change-Id: I834671920624de60bbf72bffc8b40a70079c8cea
    Signed-off-by: Arif Ali <arif-ali@ubuntu.com>
    arif-ali committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    ad303e7 View commit details
    Browse the repository at this point in the history
Loading