Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openstack/ironic-python-agent
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: openstack/ironic-python-agent
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: unmaintained/zed
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 22 files changed
  • 7 contributors

Commits on Sep 23, 2022

  1. Update .gitreview for stable/zed

    Change-Id: I90bb4608e46c45259542993f04253026cedf4f0b
    openstackadmin committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    75e15dc View commit details
    Browse the repository at this point in the history
  2. Update TOX_CONSTRAINTS_FILE for stable/zed

    Update the URL to the upper-constraints file to point to the redirect
    rule on releases.openstack.org so that anyone working on this branch
    will switch to the correct upper-constraints list automatically when
    the requirements repository branches.
    
    Until the requirements repository has as stable/zed branch, tests will
    continue to use the upper-constraints list on master.
    
    Change-Id: I67f8b3e937f81ab9271b89f1f0bb10cd762bfa74
    openstackadmin committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    ae2fe94 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Fixes for tox 4.0

    - passenv needed better structure
    - usedevelop no longer allowed alongside skipsdist
    
    Change-Id: I22dae3b1e4cca2dc328c21e889acf7fe98a80e0b
    jayofdoom committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    72dd569 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Make reno ignore bugfix eol tags

    Reno was assuming all tags ending in -eol represented an old, EOL'd
    stable branch. That's not true for Ironic projects which have bugfix
    branches. Update the regexp to exclude those branches.
    
    Co-Authored-By: Adam McArthur <adam@mcaq.me>
    Change-Id: I265969ab40a98a02962c2fc8460b6519ab576f99
    (cherry picked from commit f8fc7e5)
    jayofdoom and Sharpz7 committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    fa7e33b View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Fix UTF-16 result handling for efibootmgr

    The tl;dr is that UEFI NVRAM is in encoded
    in UTF-16, and when we run the efibootmgr command,
    we can get unicode characters back.
    
    Except we previously were forcing everything to be
    treated as UTF-8 due to the way oslo.concurrency's
    processutils module works.
    
    This could be observed with UTF character 0x00FF
    which raises up a nice exception when we try to
    decode it.
    
    Anyhow! while fixing handling of this, we discovered
    we could get basically the cruft out of the NVRAM,
    by getting what was most likey a truncated string
    out of our own test VMs. As such, we need to also
    permit decoding to be tollerant of failures.
    This could be binary data or as simple as flipped
    bits which get interpretted invalid characters.
    As such, we have introduced such data into one of our
    tests involving UEFI record de-duplication.
    
    Closes-Bug: 2015602
    Change-Id: I006535bf124379ed65443c7b283bc99ecc95568b
    (cherry picked from commit 76accfb)
    juliakreger committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    09c3c41 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Handle the node being locked

    If the node is locked, a lookup cannot be performed when an agent
    token needs to be generated, which tends to error like this:
    
      ironic_python_agent.ironic_api_client [-] Failed looking up node
      with addresses '00:6f:bb:34:b3:4d,00:6f:bb:34:b3:4b' at
      https://172.22.0.2:6385. Error 409: Node
      c25e451b-d2fb-4168-b690-f15bc8365520 is locked by host 172.22.0.2,
      please retry after the current operation is completed..
      Check if inspection has completed.
    
    Problem is, if we keep pounding on the door, we can actually worsen
    the situation, and previously we would just just let tenacity
    retry.
    
    We will now hold for 30 seconds before proceeding, so we have
    hopefully allowed the operation to complete.
    
    Also fixes the error logging to help human's sanity.
    
    Change-Id: I97d3e27e2adb731794a7746737d3788c6e7977a0
    (cherry picked from commit 5ed520d)
    juliakreger committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    06214d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. preserve/handle config drives on 4k block devices

    When an underlying block device (or driver) only supports 4KB IO,
    this can cause some issues with aspects like using an ISO9660 filesystem
    which can only support a maximum of 2KB IO.
    
    The agent will now attempt to mount the filesystem *before* deleting the
    supplied file, and should that fail it will mount the configuration drive
    file from the ramdisk utilizing a loopback, and then extract the contents
    of the ramdisk into a newly created VFAT filesystem which supports 4KB
    block IO.
    
    Closes-Bug: #2028002
    Change-Id: I336acb8e8eb5a02dde2f5e24c258e23797d200ee
    (cherry picked from commit b6c263a)
    juliakreger committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5a78bf2 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Conditional creation of RAIDed ESP for UEFI Software RAID

    Rebuilding an instance on a RAIDed ESPs will fail due to sgdisk
    running against an non-clean disk and bailing out. Check if there
    is a RAIDed ESP already and skip creation if it exists.
    
    Change-Id: I13617ae77515a9d34bc4bb3caf9fae73d5e4e578
    (cherry picked from commit 286d667)
    arnewiebalck committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    256dfe4 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Configuration menu
    Copy the full SHA
    f1c519a View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Update .gitreview for unmaintained/zed

    Change-Id: I75ffadbcb790c47eab8ac74fa8f96c7b189cf6b6
    openstackadmin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f271277 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Warn about CVE-2024-44082

    Unmaintained Ironic-Python-Agent branches will not be patched against
    CVE-2024-44082. This patch updates the release notes and readme
    instructing deployers how to mitigate their risk using the provided
    Ironic conductor patches.
    
    Related-Bug: 2071740
    Change-Id: Ie4aeef4af01ead5c18b359a22ab488de0c35248a
    jayofdoom committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a1b9170 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2026

  1. Fix CI issues

    This is a combination of 2 commits, squashed together in order to make
    all jobs pass.
    
    This is the 1st commit message:
    
    Remove non RE2 job config
    
    This causees a linting failure, and the equivalent of this rule was
    removed later in I64909aa932635b729cc85717dc241ae31798b558
    
    Original-Change-Id: Id8e1a0901090f062ff36101f07acafe01a98a67b
    (cherry picked from commit b39d9d6)
    (cherry picked from commit a488be6)
    
    This is the commit message #2:
    
    ci: Pin setuptools to a range that still ships
    
    Recent setuptools releases (82.0.0 and later) have removed the
    ``pkg_resources`` module. Our docs environment still depends on
    ``pkg_resources`` transitively via ``openstackdocstheme/pbr``,
    causing import error when run under newer environments.
    
    Modeled off of CID's ironic commit.
    
    NOTE(elod.illes): ironic-python-agent-builder's zed branch moved to EOL
    so it has to be used from zed-eol tag for the jobs. Furthermore,
    sushy-tools is cycle independent project. in Zed release 0.21.0 version
    was officially used.
    metalsmith jobs used centos8 which is not available anymore in zuul,
    hence this patch removes them from the gate.
    Additionally, ipa-tempest-bios-ipmi-direct-src job and
    ipa-tempest-uefi-redfish-vmedia-src job are intermittently failing,
    which makes the gate unstable and the error seems to be environment
    related. Setting them as non-voting to do not waste CI resource.
    
    Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
    Change-Id: Ie69c2398ff2d4f807cca40df2cca0f45298a133f
    Signed-off-by: Clif Houck <me@clifhouck.com>
    (cherry picked from commit 0474f30)
    Signed-off-by: Elod Illes <elod.illes@est.tech>
    steveb authored and Elod Illes committed Jul 2, 2026
    Configuration menu
    Copy the full SHA
    8740cd5 View commit details
    Browse the repository at this point in the history
Loading