fix(compass): add main-footer#7988
Merged
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7988.surge.sh A11y report: https://pf-pr-7988-a11y.surge.sh |
srambach
approved these changes
Nov 11, 2025
srambach
left a comment
srambach
left a comment
Member
There was a problem hiding this comment.
Looks good. Aside - might be nice to use the example CSS to shorten the example height but that's separate.
|
@mcoker I think it should be larger / match the gap of the rest of the main layout but i'll defer to @andrew-ronaldson when he's back! |
Collaborator
|
🎉 This PR is included in version 6.5.0-prerelease.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
Looks like the spacing around the left/right actions is gone. |
Contributor
Author
|
@andrew-ronaldson yeah that happened in another PR but should be fixed now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7938
@lboehling or @andrew-ronaldson for the chatbot message bar, should the space between it and the section above (the row gap) be tighter like this where it matches the space/row-gap between sections in the main area?
Or should it have more space, which matches the gap that's used for the main layout