Censor Fixes

KieranFYI · KieranFYI · commit 7fbd927a46f8 · 2022-02-12T18:37:59.000Z
diff --git a/src/Model/Base/BuildError.php b/src/Model/Base/BuildError.php
@@ -115,11 +115,6 @@ public function setMessage(string $value): bool
         return $this->setData('message', $value);
     }
 
-    public function getCreateDate(): ?DateTime
-    {
-        return $this->getData('create_date');
-    }
-
     public function getHash(): ?string
     {
         return $this->getData('hash');
diff --git a/src/Model/Build.php b/src/Model/Build.php
@@ -350,22 +350,15 @@ protected function getZeroConfigPlugins()
 
     /**
      * Allows specific build types (e.g. Github) to report violations back to their respective services.
-     *
-     * @param string  $plugin
-     * @param string  $message
-     * @param int     $severity
-     * @param string  $file
-     * @param int     $lineStart
-     * @param int     $lineEnd
      */
     public function reportError(
         Builder $builder,
-        $plugin,
-        $message,
-        $severity = BuildError::SEVERITY_NORMAL,
-        $file = null,
-        $lineStart = null,
-        $lineEnd = null
+        string $plugin,
+        string $message,
+        int $severity = BuildError::SEVERITY_NORMAL,
+        ?string $file = null,
+        ?int $lineStart = null,
+        ?int $lineEnd = null
     ) {
         $writer = $builder->getBuildErrorWriter();
         $writer->write(
diff --git a/src/Store/BuildErrorWriter.php b/src/Store/BuildErrorWriter.php
@@ -73,18 +73,18 @@ public function write(
         $hash       = BuildError::generateHash($plugin, $file, $lineStart, $lineEnd, $severity, $message);
 
         $this->errors[] = [
-            'plugin'      => (string)$plugin,
-            'message'     => (string)$message,
-            'severity'    => (int)$severity,
-            'file'        => !\is_null($file) ? (string)$file : null,
-            'line_start'  => !\is_null($lineStart) ? (int)$lineStart : null,
-            'line_end'    => !\is_null($lineEnd) ? (int)$lineEnd : null,
+            'plugin'      => $plugin,
+            'message'     => $message,
+            'severity'    => $severity,
+            'file'        => $file,
+            'line_start'  => $lineStart,
+            'line_end'    => $lineEnd,
             'create_date' => $createdDate->format('Y-m-d H:i:s'),
             'hash'        => $hash,
             'is_new'      => $errorStore->getIsNewError($this->projectId, $hash) ? 1 : 0,
         ];
 
-        if (\count($this->errors) >= $this->bufferSize) {
+        if (count($this->errors) >= $this->bufferSize) {
             $this->flush();
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -115,11 +115,6 @@ public function setMessage(string $value): bool`
`115`	`115`	`return $this->setData('message', $value);`
`116`	`116`	`}`
`117`	`117`
`118`		`- public function getCreateDate(): ?DateTime`
`119`		`- {`
`120`		`- return $this->getData('create_date');`
`121`		`- }`
`122`		`-`
`123`	`118`	`public function getHash(): ?string`
`124`	`119`	`{`
`125`	`120`	`return $this->getData('hash');`