Add rebuild with debug button. Issue #208.

corpsee · corpsee · commit d3a83ac89b06 · 2018-09-04T19:36:46.000+07:00
diff --git a/src/Controller/BuildController.php b/src/Controller/BuildController.php
@@ -126,14 +126,19 @@ public function view($buildId)
         $rebuild     = Lang::get('rebuild_now');
         $rebuildLink = APP_URL . 'build/rebuild/' . $build->getId();
 
+        $rebuildDebug = Lang::get('rebuild_now_debug');
+
         $delete     = Lang::get('delete_build');
         $deleteLink = APP_URL . 'build/delete/' . $build->getId();
 
         $project = Factory::getStore('Project')->getByPrimaryKey($build->getProjectId());
 
         $actions = '';
         if (!$project->getArchived()) {
-            $actions .= "<a class=\"btn btn-default\" href=\"{$rebuildLink}\">{$rebuild}</a> ";
+            if ($this->currentUserIsAdmin()) {
+                $actions .= "<a class=\"btn btn-danger\" href=\"{$rebuildLink}?debug=1\">{$rebuildDebug}</a> ";
+            }
+            $actions .= "<a class=\"btn btn-success\" href=\"{$rebuildLink}\">{$rebuild}</a> ";
         }
 
         if ($this->currentUserIsAdmin()) {
@@ -239,8 +244,13 @@ protected function getPaginatorHtml($buildId, $plugin, $severity, $isNew, $total
     }
 
     /**
-    * Create a build using an existing build as a template:
-    */
+     * Create a build using an existing build as a template:
+     *
+     * @param $buildId
+     *
+     * @return RedirectResponse
+     * @throws NotFoundException
+     */
     public function rebuild($buildId)
     {
         $copy    = BuildFactory::getBuildById($buildId);
@@ -250,6 +260,12 @@ public function rebuild($buildId)
             throw new NotFoundException(Lang::get('build_x_not_found', $buildId));
         }
 
+        $debug = (boolean)$this->getParam('debug', false);
+
+        if ($debug && $this->currentUserIsAdmin()) {
+            $copy->addExtraValue('debug', true);
+        }
+
         $build = $this->buildService->createDuplicateBuild($copy);
 
         if ($this->buildService->queueError) {
diff --git a/src/Controller/ProjectController.php b/src/Controller/ProjectController.php
@@ -208,7 +208,6 @@ public function build($projectId)
         }
 
         $extra = null;
-
         if ($debug && $this->currentUserIsAdmin()) {
             $extra = [
                 'debug' => true,
diff --git a/src/Languages/lang.en.php b/src/Languages/lang.en.php
@@ -194,7 +194,8 @@
     'new'               => 'New',
     'build_x_not_found' => 'Build with ID %d does not exist.',
     'build_n'           => 'Build %d',
-    'rebuild_now'       => 'Rebuild Now',
+    'rebuild_now'       => 'Rebuild now',
+    'rebuild_now_debug' => 'Rebuild now with debug',
 
     'all_errors' => 'All errors',
     'only_new'   => 'Only new errors',
diff --git a/src/Languages/lang.ru.php b/src/Languages/lang.ru.php
@@ -187,7 +187,8 @@
     'is_new'            => 'Новая?',
     'build_x_not_found' => 'Сборки с ID %d не существует.',
     'build_n'           => 'Сборка %d',
-    'rebuild_now'       => 'Пересобрать сейчас',
+    'rebuild_now'       => 'Пересобрать',
+    'rebuild_now_debug' => 'Пересобрать в режиме отладки',
 
     'all_errors' => 'Все ошибки',
     'only_new'   => 'Только новые',

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,6 @@ public function build($projectId)`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`$extra = null;`
`211`		`-`
`212`	`211`	`if ($debug && $this->currentUserIsAdmin()) {`
`213`	`212`	`$extra = [`
`214`	`213`	`'debug' => true,`