Remove json serialization dependency. Please use external visitor instead

Kirill Nesmeyanov · Kirill Nesmeyanov · commit dd360fab2a4e · 2024-04-06T16:42:57.000+03:00
diff --git a/composer.json b/composer.json
@@ -9,8 +9,7 @@
         "issues": "https://github.com/php-type-language/phpdoc/issues"
     },
     "require": {
-        "php": "^8.1",
-        "ext-json": "*"
+        "php": "^8.1"
     },
     "autoload": {
         "psr-4": {
diff --git a/src/DocBlock.php b/src/DocBlock.php
@@ -21,7 +21,6 @@ final class DocBlock implements
     OptionalDescriptionProviderInterface,
     TagsProviderInterface,
     \IteratorAggregate,
-    \JsonSerializable,
     \ArrayAccess,
     \Countable
 {
@@ -95,14 +94,6 @@ public function getIterator(): \Traversable
         return new \ArrayIterator($this->tags);
     }
 
-    public function jsonSerialize(): array
-    {
-        return [
-            'description' => $this->description,
-            'tags' => $this->tags,
-        ];
-    }
-
     /**
      * @return int<0, max>
      */
diff --git a/src/Tag/Description/Description.php b/src/Tag/Description/Description.php
@@ -37,11 +37,6 @@ public static function fromStringableOrNull(string|\Stringable|null $description
         return self::fromStringable($description);
     }
 
-    public function jsonSerialize(): string
-    {
-        return $this->value;
-    }
-
     public function __toString(): string
     {
         return $this->value;
diff --git a/src/Tag/Description/DescriptionInterface.php b/src/Tag/Description/DescriptionInterface.php
@@ -8,7 +8,7 @@
  * Any class that implements this interface is a description object
  * that can be represented as a raw string scalar value.
  */
-interface DescriptionInterface extends \JsonSerializable, \Stringable
+interface DescriptionInterface extends \Stringable
 {
     /**
      * Returns a plain string representation of this description.
diff --git a/src/Tag/Description/TaggedDescription.php b/src/Tag/Description/TaggedDescription.php
@@ -88,11 +88,6 @@ public function offsetUnset(mixed $offset): void
         throw new \BadMethodCallException(static::class . ' objects are immutable');
     }
 
-    public function jsonSerialize(): array
-    {
-        return $this->components;
-    }
-
     public function __toString(): string
     {
         return \implode('', $this->components);
diff --git a/src/Tag/Tag.php b/src/Tag/Tag.php
@@ -31,15 +31,6 @@ public function getDescription(): ?DescriptionInterface
         return $this->description;
     }
 
-    public function jsonSerialize(): array
-    {
-        return \array_filter([
-            'kind' => static::class,
-            'name' => $this->name,
-            'description' => $this->description,
-        ], static fn(mixed $value): bool => $value !== null);
-    }
-
     public function __toString(): string
     {
         if ($this->description === null) {
diff --git a/src/Tag/TagInterface.php b/src/Tag/TagInterface.php
@@ -6,10 +6,7 @@
 
 use TypeLang\PHPDoc\Tag\Description\OptionalDescriptionProviderInterface;
 
-interface TagInterface extends
-    OptionalDescriptionProviderInterface,
-    \JsonSerializable,
-    \Stringable
+interface TagInterface extends OptionalDescriptionProviderInterface, \Stringable
 {
     /**
      * Returns the non-empty tag name string without the '@' prefix.

Original file line number	Diff line number	Diff line change
`@@ -37,11 +37,6 @@ public static function fromStringableOrNull(string\|\Stringable\|null $description`
`37`	`37`	`return self::fromStringable($description);`
`38`	`38`	`}`
`39`	`39`
`40`		`- public function jsonSerialize(): string`
`41`		`- {`
`42`		`- return $this->value;`
`43`		`- }`
`44`		`-`
`45`	`40`	`public function __toString(): string`
`46`	`41`	`{`
`47`	`42`	`return $this->value;`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`* Any class that implements this interface is a description object`
`9`	`9`	`* that can be represented as a raw string scalar value.`
`10`	`10`	`*/`
`11`		`-interface DescriptionInterface extends \JsonSerializable, \Stringable`
	`11`	`+interface DescriptionInterface extends \Stringable`
`12`	`12`	`{`
`13`	`13`	`/**`
`14`	`14`	`* Returns a plain string representation of this description.`
Original file line number	Diff line number	Diff line change
`@@ -88,11 +88,6 @@ public function offsetUnset(mixed $offset): void`
`88`	`88`	`throw new \BadMethodCallException(static::class . ' objects are immutable');`
`89`	`89`	`}`
`90`	`90`
`91`		`- public function jsonSerialize(): array`
`92`		`- {`
`93`		`- return $this->components;`
`94`		`- }`
`95`		`-`
`96`	`91`	`public function __toString(): string`
`97`	`92`	`{`
`98`	`93`	`return \implode('', $this->components);`