Minor code cleanup

prdickson · prdickson · commit 6e6712915d31 · 2018-05-20T17:25:44.000+01:00
diff --git a/.flake8 b/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+max-line-length = 120
diff --git a/requirements.in b/requirements.in
@@ -1,7 +1,7 @@
 django>=1.11,<2.0
 Pillow>=3.4.1,<3.5
 psycopg2>=2.6.2,<2.7
-djangorestframework
-django-filter
-django-extensions
-requests
+djangorestframework>=3.8.2
+django-filter>=1.1.0
+django-extensions>=2.0.7
+requests>=2.18.4
diff --git a/shiptrader/management/commands/import_starships.py b/shiptrader/management/commands/import_starships.py
@@ -1,5 +1,5 @@
 import requests
-from django.core.management.base import BaseCommand, CommandError
+from django.core.management.base import BaseCommand
 
 from shiptrader.models import Starship
 
@@ -18,6 +18,7 @@ def handle(self, *args, **options):
             url = response_json['next']
             starships += [build_starship(result) for result in response_json['results']]
 
+        Starship.objects.all().delete()
         Starship.objects.bulk_create(starships)
 
 
diff --git a/shiptrader/serializers.py b/shiptrader/serializers.py
@@ -17,4 +17,4 @@ class Meta:
 class ListingUpdateSerializer(serializers.ModelSerializer):
     class Meta:
         model = Listing
-        fields = ('active',)
+        fields = ('active',)
diff --git a/shiptrader/tests/test_import_starships.py b/shiptrader/tests/test_import_starships.py
@@ -1,6 +1,5 @@
 from django.core.management import call_command
 from django.test import TestCase
-from rest_framework.reverse import reverse
 
 from shiptrader.models import Starship
 
diff --git a/shiptrader/tests/test_views.py b/shiptrader/tests/test_views.py
@@ -35,7 +35,7 @@ def test_can_get_starships(self):
     def test_can_get_listings(self):
         ship = Starship.objects.get(name='Ship 1')
 
-        self.client.post(reverse('listing-list'), {'name':'New Listing 1', 'price': 5,
+        self.client.post(reverse('listing-list'), {'name': 'New Listing 1', 'price': 5,
                                                    'ship_type': ship.id, 'active': False})
 
         listing = Listing.objects.all().first()
