Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: purescript/purescript-console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: purescript-lua/purescript-lua-console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 23 files changed
  • 3 contributors

Commits on Mar 29, 2023

  1. Reset repo after fork

    Unisay committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    78b2549 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Wrapped foreigns

    Unisay committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    66f1ba2 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2026

  1. fix: stop ignoring timer labels with a named arg, move CI to nix (#64)

    The `time`/`timeLog`/`timeEnd` FFI stubs took a label parameter `s` but
    never used it (the stub just errors), so luacheck flagged an unused
    argument. Rename it to `_s` to mark it deliberately unused; the stubs
    still fail loudly because Lua has no console-timer equivalent.
    
    Also moves CI off the dead npm/bower/setup-purescript flow onto the nix
    + overlay canon used by the other package-set forks: `scripts/build`
    under `set -euo pipefail`, luacheck `--std lua51 --no-unused-args`, and
    drops the broken pulp/node `scripts/test`.
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    9b24b17 View commit details
    Browse the repository at this point in the history
  2. chore: bump pslua flake input so codegen creates the dist dir

    CI built on a 2024-03 pslua pin that wrote --lua-output-file without
    creating the parent dir, so a fresh checkout failed with
    `dist/Effect_Console.lua: withFile: does not exist`. Current pslua
    ensures the output dir exists (the withOutputFile fix).
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    99cd31e View commit details
    Browse the repository at this point in the history
  3. Merge pull request #3 from Unisay/fix/console-overlay-ci

    fix: stop ignoring timer labels with a named arg, move CI to nix (#64)
    Unisay authored Jun 14, 2026
    Configuration menu
    Copy the full SHA
    61e0116 View commit details
    Browse the repository at this point in the history
  4. chore: migrate flake to purescript-overlay canon, add AGENTS.md

    Move the dev shell off easy-purescript-nix onto the shared
    purescript-overlay (purs 0.15.16, spago 0.21.0, lua51). Add AGENTS.md as
    the single agent instruction file + CLAUDE.md @-import. Drop dead JS-era
    files. Tooling and docs only.
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    4446329 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #4 from Unisay/chore/agents-md-and-canon-ci

    chore: migrate flake to the purescript-overlay canon, add AGENTS.md
    Unisay authored Jun 14, 2026
    Configuration menu
    Copy the full SHA
    3b1b1ec View commit details
    Browse the repository at this point in the history
  6. chore: point pslua + package-set links at purescript-lua org

    Repos moved from Unisay/* to the purescript-lua org. Update the pslua
    flake input and lockfile owner (same rev 94c13ce), the packages.dhall
    upstream-lua release URL, and the AGENTS.md links, so nothing relies on
    the old-owner redirect.
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    051cc78 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #5 from purescript-lua/chore/migrate-org-links

    chore: point pslua + package-set links at purescript-lua org
    Unisay authored Jun 14, 2026
    Configuration menu
    Copy the full SHA
    3c17969 View commit details
    Browse the repository at this point in the history
  8. chore: add treefmt formatting (nix fmt) and format the tree

    Wire treefmt via treefmt-nix: nixfmt, dhall format, purs-tidy (.tidyrc.json)
    and LuaFormatter for the FFI (.lua-format, kept over StyLua because it
    preserves the parentheses pslua's parser needs). `nix fmt` formats; the dev
    shell installs a content-based pre-commit hook and CI runs
    `nix fmt && git diff --exit-code` (content-based, since the in-place
    formatters bump mtime and would trip treefmt --fail-on-change). Lua lines
    budget 130 cols, matching the raised `luacheck --max-line-length`. The bulk
    of the diff is the first format pass.
    Unisay committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    dbe30f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2026

  1. Merge pull request #6 from purescript-lua/chore/treefmt

    chore: add treefmt formatting (nix fmt + pre-commit + CI check)
    Unisay authored Jun 15, 2026
    Configuration menu
    Copy the full SHA
    37a5000 View commit details
    Browse the repository at this point in the history
  2. chore: harden pre-commit hook (tracked .githooks/ + core.hooksPath)

    Replace the dev-shell installer that wrote .git/hooks/pre-commit with a
    tracked .githooks/pre-commit wired via `git config core.hooksPath .githooks`.
    
    Fixes three issues with the old hook: it gated on `[ -d .git ]` (false in
    worktrees/submodules where .git is a file), it clobbered any existing
    .git/hooks/pre-commit on every `nix develop`, and `nix fmt … || exit 0`
    swallowed real formatter failures. The new hook skips only when `nix` is
    absent (CI is the authoritative gate) and otherwise blocks on a `nix fmt`
    failure or reformat.
    Unisay committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    660ea52 View commit details
    Browse the repository at this point in the history
  3. chore: bump pslua dev input to 62e3653

    Toolchain consistency: pin the pslua dev flake input to the current
    compiler main across the ecosystem. flake.lock only; the package set
    consumes sources + FFI, not this dev input, so no re-tag is needed.
    Unisay committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    2331f7a View commit details
    Browse the repository at this point in the history
  4. fix: console.error / console.warn write to stderr

    Upstream purescript-console maps `error` and `warn` to console.error /
    console.warn, which target stderr in Node; the Lua FFI routed both through
    `print` (stdout), erasing the only behavioral distinction they have from
    `log` and breaking consumers that separate the streams. They now use
    `io.stderr:write`. `log`/`info`/`debug` stay on stdout (correct — Node's
    console.log/info/debug all target stdout).
    
    Adds a Lua 5.1 regression guard (test/regression/console.lua) and a
    scripts/test runner.
    
    Fixes purescript-lua/purescript-lua#76
    Fixes purescript-lua/purescript-lua#77
    Unisay committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    f82835a View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2026

  1. feat: migrate to the new spago (spago.yaml + published package set)

    Build against the published purescript-lua package set via
    workspace.packageSet.url instead of the old spago.dhall + packages.dhall
    (upstream-ps // upstream-lua) merge. The new spago drives spago.yaml/spago.lock
    and dropped Dhall.
    
    - spago.dhall/packages.dhall -> spago.yaml (package name lua-console; the new
      spago rejects the purescript- prefix). backend.cmd "true" keeps codegen on
      corefn; the pslua invocation from spago.dhall's `backend` now lives in
      scripts/build, run over the emitted corefn as a plain step.
    - flake.nix: spago 0.21.0 -> 1.x; drop the now-unused dhall dev-shell tool.
    - treefmt.nix: drop the dead Dhall formatter. AGENTS.md: spago 1.x, src/packages.json.
    - CI action versions bumped to current majors (checkout v5, install-nix v31).
    - Remove the upstream PureScript test source test/Main.purs (never built: old
      sources globbed src/ only, and it carries JS FFI that doesn't target Lua). The
      Lua regression tests under test/regression stay.
    Unisay committed Jun 24, 2026
    Configuration menu
    Copy the full SHA
    4bb420d View commit details
    Browse the repository at this point in the history
  2. chore: remove vestigial treefmt.toml and orphaned test/expected_outpu…

    …t.txt
    
    treefmt.toml is dead config (nix fmt formats via treefmt.nix). The
    expected_output.txt was an orphan from the old test setup; the kept
    tests live under test/regression/.
    Unisay committed Jun 24, 2026
    Configuration menu
    Copy the full SHA
    5332400 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2026

  1. docs: add scriv-managed changelog, backfill fork releases

    Adds a CHANGELOG.md managed with scriv (fragments in changelog.d/), provides
    scriv in the flake dev shell, and records the fork's Lua 5.1 FFI release line.
    Where the upstream PureScript changelog existed it is preserved below the fork
    section. The AGENTS.md Releasing note now points at the scriv flow instead of
    "no changelog entry".
    
    Part of the ecosystem-wide changelog adoption
    (purescript-lua/purescript-lua#101); canon in package-set ADR 0009.
    Unisay committed Jun 25, 2026
    Configuration menu
    Copy the full SHA
    cc5e44a View commit details
    Browse the repository at this point in the history
Loading