address initial @slivingston comments

murrayrm · murrayrm · commit 7ef09a0edbb9 · 2024-12-03T20:28:11.000-08:00
diff --git a/control/iosys.py b/control/iosys.py
@@ -46,7 +46,8 @@ def __new__(cls, input_array, signal_labels=None, trace_labels=None):
 
     def __array_finalize__(self, obj):
         # See https://numpy.org/doc/stable/user/basics.subclassing.html
-        if obj is None: return
+        if obj is None:
+            return
         self.signal_labels = getattr(obj, 'signal_labels', None)
         self.trace_labels = getattr(obj, 'trace_labels', None)
         self.data_shape = getattr(obj, 'data_shape', None)
@@ -1038,14 +1039,15 @@ def _parse_spec(syslist, spec, signame, dictname=None):
 #
 def _process_subsys_index(idx, sys_labels, slice_to_list=False):
     if not isinstance(idx, (slice, list, int)):
-        raise TypeError(f"system indices must be integers, slices, or lists")
+        raise TypeError("system indices must be integers, slices, or lists")
 
     # Convert singleton lists to integers for proper slicing (below)
     if isinstance(idx, (list, tuple)) and len(idx) == 1:
         idx = idx[0]
 
     # Convert int to slice so that numpy doesn't drop dimension
-    if isinstance(idx, int): idx = slice(idx, idx+1, 1)
+    if isinstance(idx, int):
+        idx = slice(idx, idx+1, 1)
 
     # Get label names (taking care of possibility that we were passed a list)
     labels = [sys_labels[i] for i in idx] if isinstance(idx, list) \
diff --git a/control/tests/lti_test.py b/control/tests/lti_test.py
@@ -322,7 +322,7 @@ def test_subsys_indexing(fcn, outdx, inpdx, key):
     sys = ct.rss(4, 3, 3)
     subsys = sys[key]
 
-    # Construct the system to be test
+    # Construct the system to be tested
     match fcn:
         case ct.frd:
             omega = np.logspace(-1, 1)
diff --git a/control/timeresp.py b/control/timeresp.py
@@ -243,7 +243,7 @@ class TimeResponseData:
 
          response(tranpose=True).input
 
-     See :meth:`TimeResponseData.__call__` for more information.
+    See :meth:`TimeResponseData.__call__` for more information.
 
     """
 
diff --git a/doc/conventions.rst b/doc/conventions.rst
@@ -99,8 +99,8 @@ argument::
     mag, phase, omega = response(squeeze=False)
 
 Frequency response objects are also available as named properties of the
-`response` object: `response.magnitude`, `response.phase`, and
-`response.response` (for the complex response).  For MIMO systems, these
+``response`` object: ``response.magnitude``, ``response.phase``, and
+``response.response`` (for the complex response).  For MIMO systems, these
 elements of the frequency response can be accessed using the names of the
 inputs and outputs::
 
@@ -109,9 +109,9 @@ inputs and outputs::
 where the signal names are based on the system that generated the frequency
 response.
 
-Note: The `fresp` data member is stored as a NumPy array and cannot be
-accessed with signal names.  Use `response.response` to access the complex
-frequency response using signal names.
+Note: The ``fresp`` data member is stored as a NumPy array and cannot be
+accessed with signal names.  Use ``response.response`` to access the
+complex frequency response using signal names.
 
 Discrete time systems
 ---------------------
@@ -157,8 +157,8 @@ names::
 
 Signal names for an indexed subsystem are preserved from the original
 system and the subsystem name is set according to the values of
-`control.config.defaults['iosys.indexed_system_name_prefix']` and
-`control.config.defaults['iosys.indexed_system_name_suffix']`.  The default
+``control.config.defaults['iosys.indexed_system_name_prefix']`` and
+``control.config.defaults['iosys.indexed_system_name_suffix']``.  The default
 subsystem name is the original system name with '$indexed' appended.
 
 Simulating LTI systems
@@ -271,7 +271,7 @@ such as the :func:`step_response` function applied to a MIMO system,
 which will compute the step response for each input/output pair.  See
 :class:`TimeResponseData` for more details.
 
-The input, output, and state elements of the response can be access using
+The input, output, and state elements of the response can be accessed using
 signal names in place of integer offsets::
 
     plt.plot(response. time, response.states['x[1]']
diff --git a/doc/plotting.rst b/doc/plotting.rst
@@ -292,7 +292,7 @@ Frequency response data can also be accessed directly and plotted manually::
 Access to frequency response data is available via the attributes
 ``omega``, ``magnitude``,` `phase``, and ``response``, where ``response``
 represents the complex value of the frequency response at each frequency.
-The ``magnitude``,` `phase``, and ``response`` arrays can be indexed using
+The ``magnitude``, ``phase``, and ``response`` arrays can be indexed using
 either input/output indices or signal names, with the first index
 corresponding to the output signal and the second input corresponding to
 the input signal.
