Skip to content

Commit 5189ff2

Browse files
committed
fix: use vswhere to find vcvars64.bat on Windows CI
Replace hardcoded VS 2022 Enterprise path with vswhere dynamic lookup in cpp and cppjswasm workflow templates.
1 parent 19e0124 commit 5189ff2

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

cpp/.github/workflows/build.yaml.jinja

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ jobs:
7171

7272
- name: Install dependencies
7373
run: |
74-
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
74+
for /f "usebackq tokens=*" %%i in (`vswhere -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath`) do call "%%i\VC\Auxiliary\Build\vcvars64.bat"
7575
make develop
7676
shell: cmd
7777
if: matrix.os == 'windows-latest'
@@ -131,12 +131,12 @@ jobs:
131131
- name: Make dist (Windows)
132132
run: |
133133
if exist dist rmdir /s /q dist
134-
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
134+
for /f "usebackq tokens=*" %%i in (`vswhere -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath`) do call "%%i\VC\Auxiliary\Build\vcvars64.bat"
135135
make dist-py-wheel
136136
shell: cmd
137137
env:
138138
CIBW_BUILD: {% raw %}"${{ matrix.cibuildwheel }}-win_amd64"{% endraw %}
139-
CIBW_BEFORE_ALL: call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
139+
CIBW_BEFORE_ALL: for /f "usebackq tokens=*" %i in (`vswhere -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath`) do call "%i\VC\Auxiliary\Build\vcvars64.bat"
140140
if: matrix.os == 'windows-latest'
141141

142142
- uses: actions-ext/python/test-wheel@main

cppjswasm/.github/workflows/build.yaml.jinja

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353

5454
- name: Install dependencies
5555
run: |
56-
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
56+
for /f "usebackq tokens=*" %%i in (`vswhere -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath`) do call "%%i\VC\Auxiliary\Build\vcvars64.bat"
5757
make develop
5858
shell: cmd
5959
if: matrix.os == 'windows-latest'
@@ -113,12 +113,12 @@ jobs:
113113
- name: Make dist (Windows)
114114
run: |
115115
if exist dist rmdir /s /q dist
116-
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
116+
for /f "usebackq tokens=*" %%i in (`vswhere -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath`) do call "%%i\VC\Auxiliary\Build\vcvars64.bat"
117117
make dist-py-wheel
118118
shell: cmd
119119
env:
120120
CIBW_BUILD: {% raw %}"${{ matrix.cibuildwheel }}-win_amd64"{% endraw %}
121-
CIBW_BEFORE_ALL: call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
121+
CIBW_BEFORE_ALL: for /f "usebackq tokens=*" %i in (`vswhere -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath`) do call "%i\VC\Auxiliary\Build\vcvars64.bat"
122122
if: matrix.os == 'windows-latest'
123123

124124
- uses: actions-ext/python/test-wheel@main

0 commit comments

Comments
 (0)