Skip to content

Very poor IME input response #2464

@gotoh

Description

@gotoh

Using the latest version (aa8d4a2),
SourceGit becomes very poor response for Japanese IME input while writing a commit message.
By bisect, I figured out the bad commit:
8e1b34b - project: upgrade AvaloniaEdit is bad

Finally, I found this change cause the issue.

diff --git "a/src/AvaloniaEdit/Rendering/TextView.cs" "b/src/AvaloniaEdit/Rendering/TextView.cs"
index 368ff2e108be7f9f164bce7a3e08056951879f91..7cc075d06335280605c0835f49ef0c1d1b6e3d9c
--- a/src/AvaloniaEdit/Rendering/TextView.cs
+++ b/src/AvaloniaEdit/Rendering/TextView.cs
@@ -678,6 +678,7 @@
         [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "knownLayer",
                                                          Justification = "This method is meant to invalidate only a specific layer - I just haven't figured out how to do that, yet.")]
         public void InvalidateLayer(KnownLayer knownLayer)
         {
-            InvalidateMeasure();
+            if (knownLayer == KnownLayer.Text)
+                InvalidateMeasure();
         }

The poor response might be due to a lag before redrawing.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions