Skip to content

Commit f4a5177

Browse files
nmayorsplitnmayorsplit
committed
[SDKS-7283] Update pom file to use check-style pluging
1 parent b968945 commit f4a5177

10 files changed

Lines changed: 67 additions & 49 deletions

File tree

‎.github/linter/checkstyle-suppressions.xml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?xml version="1.0"?>
22

33
<!DOCTYPE suppressions PUBLIC
4-
"-//Puppy Crawl//DTD Suppressions 1.1//EN"
5-
"http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
4+
"-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
5+
"https://checkstyle.org/dtds/suppressions_1_2.dtd">
66

77
<suppressions>
88
<suppress checks="LineLength" files=".*(test|it)[\\/]"/>

‎.github/workflows/ci.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,10 @@ jobs:
5555
if: matrix.jdk == '8' && github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && github.ref != 'refs/heads/development'
5656
run: mvn --batch-mode clean install
5757

58+
- name: Linter
59+
if: matrix.jdk == '8' && github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && github.ref != 'refs/heads/development'
60+
run: mvn checkstyle::check
61+
5862
- name: Deploy
5963
if: matrix.jdk == '8' && github.event_name == 'push' && github.ref != 'refs/heads/master' && github.ref != 'refs/heads/development'
6064
run: mvn --batch-mode deploy -P test

‎.github/workflows/linter.yml‎

Lines changed: 0 additions & 38 deletions
This file was deleted.

‎client/src/main/java/io/split/client/SplitFactoryImpl.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,8 @@ public SplitFactoryImpl(String apiToken, SplitClientConfig config) throws URISyn
184184
ImpressionsStorage impressionsStorage = new InMemoryImpressionsStorage(config.impressionsQueueSize());
185185
_splitCache = splitCache;
186186
_segmentCache = segmentCache;
187-
_telemetrySynchronizer = new TelemetryInMemorySubmitter(_httpclient, URI.create(config.telemetryURL()), telemetryStorage, splitCache, _segmentCache, telemetryStorage, _startTime);
187+
_telemetrySynchronizer = new TelemetryInMemorySubmitter(_httpclient, URI.create(config.telemetryURL()), telemetryStorage,
188+
splitCache, _segmentCache, telemetryStorage, _startTime);
188189

189190
// Segments
190191
_segmentSynchronizationTaskImp = buildSegments(config, segmentCache, splitCache);

‎client/src/main/java/io/split/engine/common/PushManagerImp.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ public static PushManagerImp build(Synchronizer synchronizer,
7979
Worker<SegmentQueueDto> segmentWorker = new SegmentsWorkerImp(synchronizer);
8080
PushStatusTracker pushStatusTracker = new PushStatusTrackerImp(statusMessages, telemetryRuntimeProducer);
8181
return new PushManagerImp(new AuthApiClientImp(authUrl, splitAPI.getHttpClient(), telemetryRuntimeProducer),
82-
EventSourceClientImp.build(streamingUrl, featureFlagsWorker, segmentWorker, pushStatusTracker, splitAPI.getSseHttpClient(), telemetryRuntimeProducer, threadFactory),
82+
EventSourceClientImp.build(streamingUrl, featureFlagsWorker, segmentWorker, pushStatusTracker, splitAPI.getSseHttpClient(),
83+
telemetryRuntimeProducer, threadFactory),
8384
featureFlagsWorker,
8485
segmentWorker,
8586
pushStatusTracker,

‎client/src/main/java/io/split/engine/common/SynchronizerImp.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,8 @@ public void refreshSplits(Long targetChangeNumber) {
186186
@Override
187187
public void localKillSplit(SplitKillNotification splitKillNotification) {
188188
if (splitKillNotification.getChangeNumber() > _splitCacheProducer.getChangeNumber()) {
189-
_splitCacheProducer.kill(splitKillNotification.getSplitName(), splitKillNotification.getDefaultTreatment(), splitKillNotification.getChangeNumber());
189+
_splitCacheProducer.kill(splitKillNotification.getSplitName(), splitKillNotification.getDefaultTreatment(),
190+
splitKillNotification.getChangeNumber());
190191
refreshSplits(splitKillNotification.getChangeNumber());
191192
}
192193
}

‎client/src/main/java/io/split/engine/experiments/SplitFetcherImp.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ public class SplitFetcherImp implements SplitFetcher {
4141
*/
4242

4343

44-
public SplitFetcherImp(SplitChangeFetcher splitChangeFetcher, SplitParser parser, SplitCacheProducer splitCacheProducer, TelemetryRuntimeProducer telemetryRuntimeProducer) {
44+
public SplitFetcherImp(SplitChangeFetcher splitChangeFetcher, SplitParser parser, SplitCacheProducer splitCacheProducer,
45+
TelemetryRuntimeProducer telemetryRuntimeProducer) {
4546
_splitChangeFetcher = checkNotNull(splitChangeFetcher);
4647
_parser = checkNotNull(parser);
4748
_splitCacheProducer = checkNotNull(splitCacheProducer);

‎client/src/main/java/io/split/engine/sse/NotificationProcessorImp.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ public class NotificationProcessorImp implements NotificationProcessor {
2626
_pushStatusTracker = checkNotNull(pushStatusTracker);
2727
}
2828

29-
public static NotificationProcessorImp build(FeatureFlagsWorker featureFlagsWorker, Worker<SegmentQueueDto> segmentWorker, PushStatusTracker pushStatusTracker) {
29+
public static NotificationProcessorImp build(FeatureFlagsWorker featureFlagsWorker, Worker<SegmentQueueDto> segmentWorker,
30+
PushStatusTracker pushStatusTracker) {
3031
return new NotificationProcessorImp(featureFlagsWorker, segmentWorker, pushStatusTracker);
3132
}
3233

‎client/src/main/java/io/split/engine/sse/workers/FeatureFlagWorkerImp.java‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ public class FeatureFlagWorkerImp extends Worker<FeatureFlagChangeNotification>
2525
private final SplitCacheProducer _splitCacheProducer;
2626
private final TelemetryRuntimeProducer _telemetryRuntimeProducer;
2727

28-
public FeatureFlagWorkerImp(Synchronizer synchronizer, SplitParser splitParser, SplitCacheProducer splitCacheProducer, TelemetryRuntimeProducer telemetryRuntimeProducer) {
28+
public FeatureFlagWorkerImp(Synchronizer synchronizer, SplitParser splitParser, SplitCacheProducer splitCacheProducer,
29+
TelemetryRuntimeProducer telemetryRuntimeProducer) {
2930
super("Feature flags");
3031
_synchronizer = checkNotNull(synchronizer);
3132
_splitParser = splitParser;
@@ -37,8 +38,8 @@ public FeatureFlagWorkerImp(Synchronizer synchronizer, SplitParser splitParser,
3738
public void kill(SplitKillNotification splitKillNotification) {
3839
try {
3940
_synchronizer.localKillSplit(splitKillNotification);
40-
_log.debug(String.format("Kill feature flag: %s, changeNumber: %s, defaultTreatment: %s", splitKillNotification.getSplitName(), splitKillNotification.getChangeNumber(),
41-
splitKillNotification.getDefaultTreatment()));
41+
_log.debug(String.format("Kill feature flag: %s, changeNumber: %s, defaultTreatment: %s", splitKillNotification.getSplitName(),
42+
splitKillNotification.getChangeNumber(), splitKillNotification.getDefaultTreatment()));
4243
} catch (Exception ex) {
4344
_log.warn(String.format("Exception on FeatureFlagWorker kill: %s", ex.getMessage()));
4445
}
@@ -61,7 +62,8 @@ private boolean addOrUpdateFeatureFlag(FeatureFlagChangeNotification featureFlag
6162
featureFlagChangeNotification.getPreviousChangeNumber() == _splitCacheProducer.getChangeNumber()) {
6263
Split featureFlag = featureFlagChangeNotification.getFeatureFlagDefinition();
6364
FeatureFlagsToUpdate featureFlagsToUpdate = processFeatureFlagChanges(_splitParser, Collections.singletonList(featureFlag));
64-
_splitCacheProducer.update(featureFlagsToUpdate.getToAdd(), featureFlagsToUpdate.getToRemove(), featureFlagChangeNotification.getChangeNumber());
65+
_splitCacheProducer.update(featureFlagsToUpdate.getToAdd(), featureFlagsToUpdate.getToRemove(),
66+
featureFlagChangeNotification.getChangeNumber());
6567
Set<String> segments = featureFlagsToUpdate.getSegments();
6668
for (String segmentName: segments) {
6769
_synchronizer.forceRefreshSegment(segmentName);

‎pom.xml‎

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,25 @@
129129
</execution>
130130
</executions>
131131
</plugin>
132+
<plugin>
133+
<groupId>org.apache.maven.plugins</groupId>
134+
<artifactId>maven-checkstyle-plugin</artifactId>
135+
<version>3.3.0</version>
136+
<executions>
137+
<execution>
138+
<id>checkstyle</id>
139+
<phase>validate</phase>
140+
<goals>
141+
<goal>check</goal>
142+
</goals>
143+
</execution>
144+
</executions>
145+
<configuration>
146+
<configLocation>.github/linter/google-java-style.xml</configLocation>
147+
<violationSeverity>warning</violationSeverity>
148+
<failOnViolation>true</failOnViolation>
149+
</configuration>
150+
</plugin>
132151
</plugins>
133152
</build>
134153
<profiles>
@@ -225,5 +244,31 @@
225244
</plugins>
226245
</build>
227246
</profile>
247+
<profile>
248+
<id>linter</id>
249+
<build>
250+
<plugins>
251+
<plugin>
252+
<groupId>org.apache.maven.plugins</groupId>
253+
<artifactId>maven-checkstyle-plugin</artifactId>
254+
<version>3.3.0</version>
255+
<executions>
256+
<execution>
257+
<id>checkstyle</id>
258+
<phase>validate</phase>
259+
<goals>
260+
<goal>check</goal>
261+
</goals>
262+
</execution>
263+
</executions>
264+
<configuration>
265+
<configLocation>.github/linter/google-java-style.xml</configLocation>
266+
<violationSeverity>warning</violationSeverity>
267+
<failOnViolation>true</failOnViolation>
268+
</configuration>
269+
</plugin>
270+
</plugins>
271+
</build>
272+
</profile>
228273
</profiles>
229274
</project>

0 commit comments

Comments
 (0)