[[ Bug 21434 ]] Force bitmap view visible for visual effects

montegoulding · montegoulding · commit 0a2e4a674f3d · 2018-07-20T10:12:28.000+10:00
This patch fixes a regresion from a previous patch that changed the behavior
of the `showBitmapView` method to only set the visibility of `m_bitmap_view` to
visible if the OpenGL view is not visible. This interfered with visual effects
as they uset the bitmap view rather than OpenGL view.
diff --git a/docs/notes/bugfix-21434.md b/docs/notes/bugfix-21434.md
@@ -0,0 +1 @@
+# Fix visual effects not working when acceleratedRendering is true on Android
diff --git a/engine/src/java/com/runrev/android/Engine.java b/engine/src/java/com/runrev/android/Engine.java
@@ -2251,7 +2251,8 @@ public void run() {
     
 	public void showBitmapView()
 	{
-		ensureBitmapViewVisibility();
+        // force visible for visual effects
+		m_bitmap_view.setVisibility(View.VISIBLE);
 	}
 
 ////////////////////////////////////////////////////////////////////////////////

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Fix visual effects not working when acceleratedRendering is true on Android`
Original file line number	Diff line number	Diff line change
`@@ -2251,7 +2251,8 @@ public void run() {`
`2251`	`2251`
`2252`	`2252`	`public void showBitmapView()`
`2253`	`2253`	`{`
`2254`		`- ensureBitmapViewVisibility();`
	`2254`	`+ // force visible for visual effects`
	`2255`	`+ m_bitmap_view.setVisibility(View.VISIBLE);`
`2255`	`2256`	`}`
`2256`	`2257`
`2257`	`2258`	`////////////////////////////////////////////////////////////////////////////////`