[[ PlayerPanning ]] Fix crash due to overrelease of m_player_item_video_output

livecodeian · livecodeian · commit b8d6f0bd1d9e · 2018-07-05T10:22:15.000+01:00
diff --git a/engine/src/mac-av-player.mm b/engine/src/mac-av-player.mm
@@ -365,6 +365,9 @@ - (void)setPlayer:(AVPlayer *)player
     
     // Finally we can release the player.
     [m_player release];
+	
+	// Release the video output
+	[m_player_item_video_output release];
     
     MCMemoryDeleteArray(m_markers);
     
@@ -727,7 +730,7 @@ - (void)setPlayer:(AVPlayer *)player
 
 		NSDictionary* t_settings = @{ (id)kCVPixelBufferPixelFormatTypeKey : [NSNumber numberWithInt:kCVPixelFormatType_32ARGB] };
 		// AVPlayerItemVideoOutput is available in OSX version >= 10.8
-		m_player_item_video_output = [[[AVPlayerItemVideoOutput alloc] initWithPixelBufferAttributes:t_settings] autorelease];;
+		m_player_item_video_output = [[AVPlayerItemVideoOutput alloc] initWithPixelBufferAttributes:t_settings];;
 
 		// Now set the player of the view.
 		[m_view setPlayer: m_player];
