forked from OpenFeign/feign
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathRibbonClientTest.java
More file actions
326 lines (255 loc) · 11.9 KB
/
Copy pathRibbonClientTest.java
File metadata and controls
326 lines (255 loc) · 11.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
/*
* Copyright 2013 Netflix, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package feign.ribbon;
import static com.netflix.config.ConfigurationManager.getConfigInstance;
import static org.assertj.core.api.Assertions.assertThat;
import static org.hamcrest.core.IsEqual.equalTo;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import java.io.IOException;
import java.net.URI;
import java.net.URL;
import org.junit.After;
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TestName;
import com.netflix.client.config.CommonClientConfigKey;
import com.netflix.client.config.IClientConfig;
import okhttp3.mockwebserver.MockResponse;
import okhttp3.mockwebserver.SocketPolicy;
import okhttp3.mockwebserver.MockWebServer;
import feign.Client;
import feign.Feign;
import feign.Param;
import feign.Request;
import feign.RequestLine;
import feign.RetryableException;
import feign.Retryer;
import feign.client.TrustingSSLSocketFactory;
public class RibbonClientTest {
@Rule
public final TestName testName = new TestName();
@Rule
public final MockWebServer server1 = new MockWebServer();
@Rule
public final MockWebServer server2 = new MockWebServer();
private static String oldRetryConfig = null;
private static final String SUN_RETRY_PROPERTY = "sun.net.http.retryPost";
@BeforeClass
public static void disableSunRetry() throws Exception {
// The Sun HTTP Client retries all requests once on an IOException, which makes testing retry code harder than would
// be ideal. We can only disable it for post, so lets at least do that.
oldRetryConfig = System.setProperty(SUN_RETRY_PROPERTY, "false");
}
@AfterClass
public static void resetSunRetry() throws Exception {
if (oldRetryConfig == null) {
System.clearProperty(SUN_RETRY_PROPERTY);
} else {
System.setProperty(SUN_RETRY_PROPERTY, oldRetryConfig);
}
}
static String hostAndPort(URL url) {
// our build slaves have underscores in their hostnames which aren't permitted by ribbon
return "localhost:" + url.getPort();
}
@Test
public void loadBalancingDefaultPolicyRoundRobin() throws IOException, InterruptedException {
server1.enqueue(new MockResponse().setBody("success!"));
server2.enqueue(new MockResponse().setBody("success!"));
getConfigInstance().setProperty(serverListKey(),
hostAndPort(server1.url("").url()) + "," + hostAndPort(
server2.url("").url()));
TestInterface api = Feign.builder().client(RibbonClient.create())
.target(TestInterface.class, "http://" + client());
api.post();
api.post();
assertEquals(1, server1.getRequestCount());
assertEquals(1, server2.getRequestCount());
// TODO: verify ribbon stats match
// assertEquals(target.lb().getLoadBalancerStats().getSingleServerStat())
}
@Test
public void ioExceptionRetry() throws IOException, InterruptedException {
server1.enqueue(new MockResponse().setSocketPolicy(SocketPolicy.DISCONNECT_AT_START));
server1.enqueue(new MockResponse().setBody("success!"));
getConfigInstance().setProperty(serverListKey(), hostAndPort(server1.url("").url()));
TestInterface api = Feign.builder().client(RibbonClient.create())
.target(TestInterface.class, "http://" + client());
api.post();
assertEquals(2, server1.getRequestCount());
// TODO: verify ribbon stats match
// assertEquals(target.lb().getLoadBalancerStats().getSingleServerStat())
}
@Test
public void ioExceptionFailsAfterTooManyFailures() throws IOException, InterruptedException {
server1.enqueue(new MockResponse().setSocketPolicy(SocketPolicy.DISCONNECT_AT_START));
getConfigInstance().setProperty(serverListKey(), hostAndPort(server1.url("").url()));
TestInterface
api =
Feign.builder().client(RibbonClient.create()).retryer(Retryer.NEVER_RETRY)
.target(TestInterface.class, "http://" + client());
try {
api.post();
fail("No exception thrown");
} catch (RetryableException ignored) {
}
//TODO: why are these retrying?
assertThat(server1.getRequestCount()).isGreaterThanOrEqualTo(1);
// TODO: verify ribbon stats match
// assertEquals(target.lb().getLoadBalancerStats().getSingleServerStat())
}
@Test
public void ribbonRetryConfigurationOnSameServer() throws IOException, InterruptedException {
server1.enqueue(new MockResponse().setSocketPolicy(SocketPolicy.DISCONNECT_AT_START));
server1.enqueue(new MockResponse().setSocketPolicy(SocketPolicy.DISCONNECT_AT_START));
server2.enqueue(new MockResponse().setSocketPolicy(SocketPolicy.DISCONNECT_AT_START));
server2.enqueue(new MockResponse().setSocketPolicy(SocketPolicy.DISCONNECT_AT_START));
getConfigInstance().setProperty(serverListKey(), hostAndPort(server1.url("").url()) + "," + hostAndPort(server2.url("").url()));
getConfigInstance().setProperty(client() + ".ribbon.MaxAutoRetries", 1);
TestInterface api = Feign.builder().client(RibbonClient.create()).retryer(Retryer.NEVER_RETRY)
.target(TestInterface.class, "http://" + client());
try {
api.post();
fail("No exception thrown");
} catch (RetryableException ignored) {
}
assertTrue(server1.getRequestCount() >= 2 || server2.getRequestCount() >= 2);
assertThat(server1.getRequestCount() + server2.getRequestCount()).isGreaterThanOrEqualTo(2);
// TODO: verify ribbon stats match
// assertEquals(target.lb().getLoadBalancerStats().getSingleServerStat())
}
@Test
public void ribbonRetryConfigurationOnMultipleServers() throws IOException, InterruptedException {
server1.enqueue(new MockResponse().setSocketPolicy(SocketPolicy.DISCONNECT_AT_START));
server1.enqueue(new MockResponse().setSocketPolicy(SocketPolicy.DISCONNECT_AT_START));
server2.enqueue(new MockResponse().setSocketPolicy(SocketPolicy.DISCONNECT_AT_START));
server2.enqueue(new MockResponse().setSocketPolicy(SocketPolicy.DISCONNECT_AT_START));
getConfigInstance().setProperty(serverListKey(), hostAndPort(server1.url("").url()) + "," + hostAndPort(server2.url("").url()));
getConfigInstance().setProperty(client() + ".ribbon.MaxAutoRetriesNextServer", 1);
TestInterface api = Feign.builder().client(RibbonClient.create()).retryer(Retryer.NEVER_RETRY)
.target(TestInterface.class, "http://" + client());
try {
api.post();
fail("No exception thrown");
} catch (RetryableException ignored) {
}
assertThat(server1.getRequestCount()).isGreaterThanOrEqualTo(1);
assertThat(server1.getRequestCount()).isGreaterThanOrEqualTo(1);
// TODO: verify ribbon stats match
// assertEquals(target.lb().getLoadBalancerStats().getSingleServerStat())
}
/*
This test-case replicates a bug that occurs when using RibbonRequest with a query string.
The querystrings would not be URL-encoded, leading to invalid HTTP-requests if the query string contained
invalid characters (ex. space).
*/
@Test
public void urlEncodeQueryStringParameters() throws IOException, InterruptedException {
String queryStringValue = "some string with space";
String expectedQueryStringValue = "some+string+with+space";
String expectedRequestLine = String.format("GET /?a=%s HTTP/1.1", expectedQueryStringValue);
server1.enqueue(new MockResponse().setBody("success!"));
getConfigInstance().setProperty(serverListKey(), hostAndPort(server1.url("").url()));
TestInterface api = Feign.builder().client(RibbonClient.create())
.target(TestInterface.class, "http://" + client());
api.getWithQueryParameters(queryStringValue);
final String recordedRequestLine = server1.takeRequest().getRequestLine();
assertEquals(recordedRequestLine, expectedRequestLine);
}
@Test
public void testHTTPSViaRibbon() {
Client trustSSLSockets = new Client.Default(TrustingSSLSocketFactory.get(), null);
server1.useHttps(TrustingSSLSocketFactory.get("localhost"), false);
server1.enqueue(new MockResponse().setBody("success!"));
getConfigInstance().setProperty(serverListKey(), hostAndPort(server1.url("").url()));
TestInterface api = Feign.builder().client(RibbonClient.builder().delegate(trustSSLSockets).build())
.target(TestInterface.class, "https://" + client());
api.post();
assertEquals(1, server1.getRequestCount());
}
@Test
public void ioExceptionRetryWithBuilder() throws IOException, InterruptedException {
server1.enqueue(new MockResponse().setSocketPolicy(SocketPolicy.DISCONNECT_AT_START));
server1.enqueue(new MockResponse().setBody("success!"));
getConfigInstance().setProperty(serverListKey(), hostAndPort(server1.url("").url()));
TestInterface api =
Feign.builder().client(RibbonClient.create())
.target(TestInterface.class, "http://" + client());
api.post();
assertEquals(server1.getRequestCount(), 2);
// TODO: verify ribbon stats match
// assertEquals(target.lb().getLoadBalancerStats().getSingleServerStat())
}
@Test
public void ribbonRetryOnStatusCodes() throws IOException, InterruptedException {
server1.enqueue(new MockResponse().setResponseCode(502));
server2.enqueue(new MockResponse().setResponseCode(503));
getConfigInstance().setProperty(serverListKey(), hostAndPort(server1.url("").url()) + "," + hostAndPort(server2.url("").url()));
getConfigInstance().setProperty(client() + ".ribbon.MaxAutoRetriesNextServer", 1);
getConfigInstance().setProperty(client() + ".ribbon.RetryableStatusCodes", "503,502");
TestInterface
api =
Feign.builder().client(RibbonClient.create()).retryer(Retryer.NEVER_RETRY)
.target(TestInterface.class, "http://" + client());
try {
api.post();
fail("No exception thrown");
} catch (Exception ignored) {
}
assertEquals(1, server1.getRequestCount());
assertEquals(1, server2.getRequestCount());
}
@Test
public void testFeignOptionsClientConfig() {
Request.Options options = new Request.Options(1111, 22222);
IClientConfig config = new RibbonClient.FeignOptionsClientConfig(options);
assertThat(config.get(CommonClientConfigKey.ConnectTimeout),
equalTo(options.connectTimeoutMillis()));
assertThat(config.get(CommonClientConfigKey.ReadTimeout), equalTo(options.readTimeoutMillis()));
assertEquals(2, config.getProperties().size());
}
@Test
public void testCleanUrlWithMatchingHostAndPart() throws IOException {
URI uri = RibbonClient.cleanUrl("http://questions/questions/answer/123", "questions");
assertEquals("http:///questions/answer/123", uri.toString());
}
@Test
public void testCleanUrl() throws IOException {
URI uri = RibbonClient.cleanUrl("http://myservice/questions/answer/123", "myservice");
assertEquals("http:///questions/answer/123", uri.toString());
}
private String client() {
return testName.getMethodName();
}
private String serverListKey() {
return client() + ".ribbon.listOfServers";
}
@After
public void clearServerList() {
getConfigInstance().clearProperty(serverListKey());
}
interface TestInterface {
@RequestLine("POST /")
void post();
@RequestLine("GET /?a={a}")
void getWithQueryParameters(@Param("a") String a);
}
}