fix: Remove unnecessary ARIA role on the Control Bar. (#5154)

OwenEdwards · gkatsev · commit 8a0895783581 · 2018-05-11T14:31:28.000-04:00
There doesn't seem to be any point in indicating the Control Bar as a separate object - it's all just part of the video player. Perhaps in the future, if there's content which isn't part of the control bar that needs to be clearly distinguishable from the control bar, then it would make sense, but right now you don't interact with the control bar and it doesn't convey any concept of grouping. Fixes #5134
diff --git a/src/js/control-bar/control-bar.js b/src/js/control-bar/control-bar.js
@@ -39,10 +39,6 @@ class ControlBar extends Component {
     return super.createEl('div', {
       className: 'vjs-control-bar',
       dir: 'ltr'
-    }, {
-      // The control bar is a group, but we don't aria-label it to avoid
-      //  over-announcing by JAWS
-      role: 'group'
     });
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -39,10 +39,6 @@ class ControlBar extends Component {`
`39`	`39`	`return super.createEl('div', {`
`40`	`40`	`className: 'vjs-control-bar',`
`41`	`41`	`dir: 'ltr'`
`42`		`- }, {`
`43`		`- // The control bar is a group, but we don't aria-label it to avoid`
`44`		`- // over-announcing by JAWS`
`45`		`- role: 'group'`
`46`	`42`	`});`
`47`	`43`	`}`
`48`	`44`	`}`