fix(seek-bar): ensure aria-valuenow attribute in seek-bar is not NaN (#5164)

monicao · gkatsev · commit ad1bb9db5e79 · 2018-05-11T14:09:15.000-04:00
Updated the getPercent function to return 0 instead of NaN. This is in accordance with the return value in the function's jsdocs. Fixes #4960.
diff --git a/src/js/control-bar/progress-control/seek-bar.js b/src/js/control-bar/progress-control/seek-bar.js
@@ -171,7 +171,7 @@ class SeekBar extends Slider {
   getPercent() {
     const percent = this.getCurrentTime_() / this.player_.duration();
 
-    return percent >= 1 ? 1 : percent;
+    return percent >= 1 ? 1 : (percent || 0);
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ class SeekBar extends Slider {`
`171`	`171`	`getPercent() {`
`172`	`172`	`const percent = this.getCurrentTime_() / this.player_.duration();`
`173`	`173`
`174`		`- return percent >= 1 ? 1 : percent;`
	`174`	`+ return percent >= 1 ? 1 : (percent \|\| 0);`
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`/**`