Skip to content

fix: adds correct cursor pointer for the play/pause controlbar button. #5463

Merged
gkatsev merged 5 commits into
videojs:masterfrom
gjanblaszczyk:play-cursor-issue
Nov 2, 2018
Merged

fix: adds correct cursor pointer for the play/pause controlbar button. #5463
gkatsev merged 5 commits into
videojs:masterfrom
gjanblaszczyk:play-cursor-issue

Conversation

@gjanblaszczyk

@gjanblaszczyk gjanblaszczyk commented Sep 29, 2018

Copy link
Copy Markdown
Contributor

Description

A proposed fix for #5462

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome

welcome Bot commented Sep 29, 2018

Copy link
Copy Markdown

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Comment thread src/css/components/_play-pause.scss Outdated
cursor: pointer;
}
.video-js .vjs-play-control .vjs-icon-placeholder {
cursor: pointer;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is probably no longer necessary.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you are right. Fixed now.

@misteroneill

Copy link
Copy Markdown
Member

Thanks!

@jmcastor

jmcastor commented May 28, 2020 via email

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants