Skip to content

Add Welsh/Cymraeg (cy) translations#5561

Merged
gkatsev merged 2 commits into
videojs:masterfrom
carlmorris:add-welsh-cymraeg-l10n
Nov 8, 2018
Merged

Add Welsh/Cymraeg (cy) translations#5561
gkatsev merged 2 commits into
videojs:masterfrom
carlmorris:add-welsh-cymraeg-l10n

Conversation

@carlmorris

Copy link
Copy Markdown
Contributor

Description

Add completed translations for Welsh/Cymraeg.

Specific Changes proposed

New file of Welsh/Cymraeg (cy) language strings.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome

welcome Bot commented Nov 7, 2018

Copy link
Copy Markdown

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@misteroneill misteroneill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, but that's unrelated to this PR. It may need to be rebased on the latest master branch.

Thanks for the PR!

@gkatsev

gkatsev commented Nov 8, 2018

Copy link
Copy Markdown
Member

Merging even though tests failed, as they're unrelated.

@gkatsev gkatsev merged commit b2c1077 into videojs:master Nov 8, 2018
@welcome

welcome Bot commented Nov 8, 2018

Copy link
Copy Markdown

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants