chore: Lint on pre-commit with lint-staged, use npm-merge-driver#5591
Merged
Conversation
gkatsev
reviewed
Nov 15, 2018
gkatsev
approved these changes
Nov 15, 2018
brandonocasey
force-pushed
the
chore/smarter-tooling
branch
from
cebd601 to
42e10a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not having
lint-stagedornpm-merge-driver-installhas been bugging me, they make the workflow a lot quicker when committing or merging package-lock changes. It also allows us to only lint the partially staged changes that we are working on during commit/push.