Skip to content

test: add a test to check various children set to false#5670

Merged
gkatsev merged 4 commits into
masterfrom
fix/livetracker-null-check
Dec 11, 2018
Merged

test: add a test to check various children set to false#5670
gkatsev merged 4 commits into
masterfrom
fix/livetracker-null-check

Conversation

@brandonocasey

@brandonocasey brandonocasey commented Dec 10, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Added a test that should catch assertions that happen when a child is turned off on the player.
  • About to add a fix for the current assertion on liveTracker/seekToLive.

gkatsev
gkatsev reviewed Dec 10, 2018
View reviewed changes
Comment thread test/unit/player.test.js Outdated
gkatsev
gkatsev reviewed Dec 10, 2018
View reviewed changes
Comment thread test/unit/player.test.js Outdated
@brandonocasey brandonocasey force-pushed the fix/livetracker-null-check branch from 46aa738 to ef5f298 Compare December 10, 2018 21:33
@gkatsev gkatsev changed the title tests: add a test to check various children set to false test: add a test to check various children set to false Dec 11, 2018
@gkatsev gkatsev added the patch This PR can be added to a patch release. label Dec 11, 2018
@brandonocasey brandonocasey force-pushed the fix/livetracker-null-check branch from 5f99de4 to 16a5257 Compare December 11, 2018 17:42
@brandonocasey brandonocasey force-pushed the fix/livetracker-null-check branch from 16a5257 to 5a503ab Compare December 11, 2018 17:45
@brandonocasey brandonocasey force-pushed the fix/livetracker-null-check branch from 5a503ab to 0b66579 Compare December 11, 2018 17:50
@gkatsev

gkatsev commented Dec 11, 2018

Copy link
Copy Markdown
Member

Can the sed command be run to fix the https->http issue in package-lock? Otherwise, LGTM

@brandonocasey

brandonocasey commented Dec 11, 2018

Copy link
Copy Markdown
Contributor Author

sed command done

@gkatsev gkatsev merged commit 13b42ad into master Dec 11, 2018
@gkatsev gkatsev deleted the fix/livetracker-null-check branch December 11, 2018 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@misteroneill misteroneill misteroneill approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees

No one assigned

Labels

patch This PR can be added to a patch release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brandonocasey @gkatsev @misteroneill