Nova API extensions AllocateFloatingIp returns FloatingIp instead of void

Shlomo Hakim · stefanl2@yahoo.fr · commit 677e897f340f · 2013-03-26T17:51:30.000+01:00
diff --git a/nova-client/src/main/java/org/openstack/nova/api/extensions/FloatingIpsExtension.java b/nova-client/src/main/java/org/openstack/nova/api/extensions/FloatingIpsExtension.java
@@ -9,6 +9,7 @@
 
 import org.openstack.nova.NovaCommand;
 import org.openstack.nova.model.FloatingIps;
+import org.openstack.nova.model.FloatingIp;
 
 public class FloatingIpsExtension {
 	
@@ -21,7 +22,7 @@ public FloatingIps execute(WebTarget target) {
 
 	}
 
-	public static class AllocateFloatingIp implements NovaCommand<Void> {
+	public static class AllocateFloatingIp implements NovaCommand<FloatingIp> {
 		
 		private Map<String, String> body;
 			
@@ -33,9 +34,8 @@ public AllocateFloatingIp(String pool) {
 		}
 
 		@Override
-		public Void execute(WebTarget target) {
-			target.path("os-floating-ips").request(MediaType.APPLICATION_JSON).post(Entity.json(body));
-			return null;
+		public FloatingIp execute(WebTarget target) {
+			return target.path("os-floating-ips").request(MediaType.APPLICATION_JSON).post(Entity.json(body)).readEntity(FloatingIp.class);
 		}
 
 	}

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`
`10`	`10`	`import org.openstack.nova.NovaCommand;`
`11`	`11`	`import org.openstack.nova.model.FloatingIps;`
	`12`	`+import org.openstack.nova.model.FloatingIp;`
`12`	`13`
`13`	`14`	`public class FloatingIpsExtension {`
`14`	`15`
`@@ -21,7 +22,7 @@ public FloatingIps execute(WebTarget target) {`
`21`	`22`
`22`	`23`	`}`
`23`	`24`
`24`		`- public static class AllocateFloatingIp implements NovaCommand<Void> {`
	`25`	`+ public static class AllocateFloatingIp implements NovaCommand<FloatingIp> {`
`25`	`26`
`26`	`27`	`private Map<String, String> body;`
`27`	`28`
`@@ -33,9 +34,8 @@ public AllocateFloatingIp(String pool) {`
`33`	`34`	`}`
`34`	`35`
`35`	`36`	`@Override`
`36`		`- public Void execute(WebTarget target) {`
`37`		`- target.path("os-floating-ips").request(MediaType.APPLICATION_JSON).post(Entity.json(body));`
`38`		`- return null;`
	`37`	`+ public FloatingIp execute(WebTarget target) {`
	`38`	`+ return target.path("os-floating-ips").request(MediaType.APPLICATION_JSON).post(Entity.json(body)).readEntity(FloatingIp.class);`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`}`