changeset: 93937:73086376ed3c parent: 93934:4e84e45e191b parent: 93936:2b642f2ca391 user: Serhiy Storchaka date: Sat Dec 20 17:46:05 2014 +0200 files: Lib/codecs.py Lib/test/test_codecs.py Misc/NEWS description: Issue #23071: Added missing names to codecs.__all__. Patch by Martin Panter. diff -r 4e84e45e191b -r 73086376ed3c Lib/codecs.py --- a/Lib/codecs.py Fri Dec 19 11:21:56 2014 -0500 +++ b/Lib/codecs.py Sat Dec 20 17:46:05 2014 +0200 @@ -20,6 +20,12 @@ "BOM_LE", "BOM32_BE", "BOM32_LE", "BOM64_BE", "BOM64_LE", "BOM_UTF8", "BOM_UTF16", "BOM_UTF16_LE", "BOM_UTF16_BE", "BOM_UTF32", "BOM_UTF32_LE", "BOM_UTF32_BE", + "CodecInfo", "Codec", "IncrementalEncoder", "IncrementalDecoder", + "StreamReader", "StreamWriter", + "StreamReaderWriter", "StreamRecoder", + "getencoder", "getdecoder", "getincrementalencoder", + "getincrementaldecoder", "getreader", "getwriter", + "encode", "decode", "iterencode", "iterdecode", "strict_errors", "ignore_errors", "replace_errors", "xmlcharrefreplace_errors", "backslashreplace_errors", "namereplace_errors", diff -r 4e84e45e191b -r 73086376ed3c Lib/test/test_codecs.py --- a/Lib/test/test_codecs.py Fri Dec 19 11:21:56 2014 -0500 +++ b/Lib/test/test_codecs.py Sat Dec 20 17:46:05 2014 +0200 @@ -1659,6 +1659,29 @@ c = codecs.lookup('ASCII') self.assertEqual(c.name, 'ascii') + def test_all(self): + api = ( + "encode", "decode", + "register", "CodecInfo", "Codec", "IncrementalEncoder", + "IncrementalDecoder", "StreamReader", "StreamWriter", "lookup", + "getencoder", "getdecoder", "getincrementalencoder", + "getincrementaldecoder", "getreader", "getwriter", + "register_error", "lookup_error", + "strict_errors", "replace_errors", "ignore_errors", + "xmlcharrefreplace_errors", "backslashreplace_errors", + "namereplace_errors", + "open", "EncodedFile", + "iterencode", "iterdecode", + "BOM", "BOM_BE", "BOM_LE", + "BOM_UTF8", "BOM_UTF16", "BOM_UTF16_BE", "BOM_UTF16_LE", + "BOM_UTF32", "BOM_UTF32_BE", "BOM_UTF32_LE", + "BOM32_BE", "BOM32_LE", "BOM64_BE", "BOM64_LE", # Undocumented + "StreamReaderWriter", "StreamRecoder", + ) + self.assertCountEqual(api, codecs.__all__) + for api in codecs.__all__: + getattr(codecs, api) + class StreamReaderTest(unittest.TestCase): def setUp(self): diff -r 4e84e45e191b -r 73086376ed3c Misc/NEWS --- a/Misc/NEWS Fri Dec 19 11:21:56 2014 -0500 +++ b/Misc/NEWS Sat Dec 20 17:46:05 2014 +0200 @@ -196,6 +196,8 @@ Library ------- +- Issue #23071: Added missing names to codecs.__all__. Patch by Martin Panter. + - Issue #22783: Pickling now uses the NEWOBJ opcode instead of the NEWOBJ_EX opcode if possible.