Outer loop not running

[ted_gress]

Hi

I'm working on something and it has a nested while loop. It seems like only the inner loop is running and only once;

Code:

def answer(x, y):

    idbadge = [[0 for i in range(x)] for i in range(y)]

    row = 0
    col = 0
    a = 1

    #################Detemine number of cells###############
    count = 0
    counter = 0
    i=0
    a=0
    while (a < x):
        i = i + 1
        a = a + i
        count = i
        counter = i
        print("Count is " + str(count));
        print("Counter is " + str(counter))


    row = 0
    col = 0
    a = 1
    #n = 0
    ##############Build Matrix###############

    row = 0
    col = 0
    a = 1
    t = 2

    print("Count: " + str(count))


    while col < count:
        while row < count:

            print("Row:" + str(row))
            print("Col:" + str(col))
            print("ID BADGE" + str(a))
            idbadge[row][col] = a
            row = row + 1
            a = a + row

        col = col + 1
        #t = t + 1
        #a = t


    ###############Print Out###############

    #print top row (row 0)
    #print second top row
    #continue printing until row is equal to 4


answer(10,10)

[Larz60+]

the outer loop has to run at least once for the inner loop to run.

Output:
outer iteration col  col < count  inner iteration count  row   row < count
--------------- ---  ------------ --------------- -----  ---   -----------
1               0     yes         1               4      0     yes
                                  2               4      1     yes
                                  3               4      2     yes
                                  4               4      3     No
2               1     yes         1               4      4     No
3               2     yes         1               4      4     No
4               3     yes         1               4      4     No
5               4     no

so actually the outer loop is worthless
you need to reset row to zero in first loop after each inner loop has run its course

def answer(x, y):
 
    idbadge = [[0 for i in range(x)] for i in range(y)]
 
    row = 0
    col = 0
    a = 1
 
    #################Detemine number of cells###############
    count = 0
    counter = 0
    i=0
    a=0
    while (a < x):
        i = i + 1
        a = a + i
        count = i
        counter = i
        # print("Count is " + str(count));
        # print("Counter is " + str(counter))
 
 
    row = 0
    col = 0
    a = 1
    #n = 0
    ##############Build Matrix###############
 
    row = 0
    col = 0
    a = 1
    t = 2
 
    # print("Count: " + str(count))
 
 
    while col < count:
        while row < count:
 
            # print("Row:" + str(row))
            # print("Col:" + str(col))
            print("ID BADGE" + str(a))
            idbadge[row][col] = a
            row = row + 1
            a = a + row
        row = 0
        col = col + 1
        #t = t + 1
        #a = t
 
 
    ###############Print Out###############
 
    #print top row (row 0)
    #print second top row
    #continue printing until row is equal to 4
 
 
answer(10,10)

Output:
ID BADGE1
ID BADGE2
ID BADGE4
ID BADGE7
ID BADGE11
ID BADGE12
ID BADGE14
ID BADGE17
ID BADGE21
ID BADGE22
ID BADGE24
ID BADGE27
ID BADGE31
ID BADGE32
ID BADGE34
ID BADGE37

using list comprehension this code can be reduced to a few lines

[volcano63]

idbadge = [[0 for i in range(x)] for i in range(y)]

may be re-written as

id_badge = [[0] * columns for _ in range(rows)]

Using one-letter variable - in general - is one of the most successful methods to write unreadable code. Reading PEP-8 is recommended