Output with none, print(x) in function

[Vidar567]

Do you have any suggestions how to change this None in an output value?

I have read that it is because of print(x), but... if I delete or change print(x) to return x, for loop will end at 1 number. I don't want to have list [] output just normally print(x) in function.

def oddNumbers(l=1, r=7):
    for x in range(l, r):
        if x % 2 == 0:
            pass
        else:
            print(x)

print(oddNumbers())

 
Output:

1
3
5
None

[Vidar567]

I find out to pack it into list and then unpack using loop, but to be honest I do not like it, do you have any sugesstions?

def oddNumbers(l=1, r=7):
    # Write your code here
    lista = []
    for x in range(l, r):
        if x % 2 == 0:
            pass
        else:
            lista.append(x)
    return lista
arr = oddNumbers()

for i in arr:
    print(i)

[palladium]

The problem lies in this line:

print(oddNumbers())

When oddNumbers is executed, you get 1,3,5 as expected (because the oddNumbers function prints, rather than returns, the odd numbers). However, because the function has no return value, when print() is executed on oddNumbers, you get None.

If you change the line to:

oddNumbers()

You get your desired output:

Output:
1
3
5

If you want the function to generate the list of odd numbers for you to use later, you can use a list comprehension like this:

oddnumbers = [x for x in range(1,7) if x %2 != 0]
print(oddnumbers)

Output:

Output:
[1,3,5]

[deanhystad]

I think putting a print statement in odd_numbers() is bad design. It makes the function useless. I cannot use your odd_numbers() to get a list of odd numbers for the program I am writing. I don't want the printing numbers side effect messing up the output in my program.

For something like this maybe I want a generator.

def odd_numbers(start=1, end=None):
    if start % 2 == 0:
        start += 1
    while True:
        if end and start > end:
             break
        yield start
        start += 2

# If I want to print odd numbers
print('Count from 11 to 21 by 2')
for x in odd_numbers(11, 21):
    print(x)

# If I want a list of odd nmbers
a = list(odd_numbers(1, 7))
b = [x for x in odd_numbers(13, 21)]
print('Combined lists =', a+b)

# Or an unknown number of odd numbers
odds_gen = odd_numbers()
odds = []
while sum(odds) < 100:
    odds.append(next(odds_gen))
print(f'sum{odds} = {sum(odds)}')

You would never do something like this for odd numbers. They are way too easy to generate ad hoc. But you might do this for a different sequence that is not so easy to generate and that might have several different uses.