WHILE Loop - constant variables NOT working with user input boundaries

[C0D3R]

This is my full program: https://github.com/UnknownBob123/Card-Catalogue


The only thing that is not working as intended, is the minimum and maximum number a user can input, and it is between 1-25. If I input 0, and 26, nothing happens as it continues without stopping - it is supposed to prompt the same window again, asking it to input numbers between 1-25, until then the program won't proceed. I imagine my "validate_value" function is not being called, but I am not fully certain where or why this is happening. I'd appreciate a helping hand on this! :-)

Here is the part where the issue stated above is happening.

def validate_value(value, item): 

    """Input validation: Checks that the user has input a valid value. 

    """ 

    # If the user presses the Cancel button, function is called to  

    # confirm that the user wants to exit. 

    if value == None: 
      
      value = query_cancel() 

 

    # If the user presses the OK button without entering a value, 

    # the no_value() function is called to display an error message 

    # and get input. 

    

    while value == "": 
      
      value = no_value(item) 
      

 

    # The while loop checks that input is valid (from VALUE_MIN to  

    # VALUE_MAX), and if not an error message is displayed, and the  

    # user is prompted to re-enter the value. 

    while float(value) < VALUE_MIN or float(value) > VALUE_MAX: 
      
      
      msg = "Please enter a valid value for " + item + " (from " + str(VALUE_MIN) + " to " + str(VALUE_MAX) + ")." 
      title = "ERROR" 
      value = easygui.enterbox(msg, title) 
      

 

        # If the user pressed OK without entering a value, the function 

        # is called to display and error message and get input. 

      while value == "": 
        value = no_value(item) 

 

        # If the user presses the Cancel button, function is called to  

        # confirm that the user wants to exit. 

      if value == None: 
        
        value = query_cancel()
        
        return (value) 

[deanhystad]

The function works as you expect. It keeps asking for a value until I enter a value in the range 1 to 25. I know that you are not calling this function in the code you posted yesterday in the GUI forum. Where should it be used?

Why is there so much whitespace in your program? Are you leaving a blank line after each statement or is this happening when you post the code? If you are doing it on purpose, I don't like it at all. Really makes your code hard to read. Stretches out even short functions so much they don't fit on one screen.

Your indenting is not consistent. Should always be 4 spaces. Your first indent is 4, but subsequent indents are 2 and this combined with the stretched out code makes it tough to see how things line up.

[C0D3R]

Apologies for the bad indentations and whitespaces, I will fix these and follow proper PEP-8 Conventions once I can get the program done.

When the window is blank, and I press OK without inputting anything, it does prompt the input window, however when I input 0 OR 26, it still proceeds. I think the "validate_value()" function should be called in the "get_fields()" function, not quite sure how to manipulate that code as I am still pretty much a newbie when it comes to python, and I am not familiar with that code since I did not write it. This is pretty much the only thing that I am trying to implement in my code.

[deanhystad]

Modify get_fields to do the checking.

def get_fields(msg, title, fields):
    """Get values for multiple fields.  Returns values in dictionry"""
    values = easygui.multenterbox(msg, title, fields)
  
    # Validate field values
    while True:
        missing_fields = [field for field, value in zip(fields, values) if not value.strip()]
        invalid_values = []
        for field, value in zip(fields, values):
            try:
                value = int(value)
                if not VALUE_MIN <= value <= VALUE_MAX:
                    invalid_values.append(field)  # Not in range
            except ValueError:
                invalid_values.append(field)   # Not a number

        if missing_fields:
            missing_fields = ", ".join(missing_fields)
            values = easygui.multenterbox(f"Enter values for {missing_fields}", title, fields, values)
        elif invalid_values:
            invalid_values = ", ".join(invalid_values)
            values = easygui.multenterbox(f"{invalid_values} must be in range {VALUE_MIN}..{VALUE_MAX}", title, fields, values)
        else:
            return {field:value for field, value in zip(fields, values)}

If you'd rather use the validate function you would call that in the add_combo() function.

def add_combo(): 
    '''Add new combo to menu''' 
    while True:
        combo_name = easygui.enterbox(
            "Enter Monster Card name: ",
            title = "Monster Card Name").capitalize()
  
        if check_exists(combo_name): 
            easygui.msgbox("That card name has already been used.") 
        else:
            card_catalogue[combo_name] = get_fields(
                msg="Enter Values",
                title="Monster Card Value",
                fields=("Strength", "Speed", "Stealth", "Cunning"))

            for field, value in card_catalogue[combo_name].items():
                validate_value(value, field)
    
        if not confirm("Do you want to add another monster card?"):
            break

[C0D3R]

Awesome! I used the first option to modify get_fields(). You have been extremely helpful to me on my posts, a new programmer just trying to get a grasp of how to manipulate stuff, to build a fundamental base for the future.

I am now cleaning up the code to make it more presentable, (need to work on that haha).

Wish you the best deanhystad, thank you for taking time out of your day to guide people on the forums.